diff options
| author | Stefan Metzmacher <metze@samba.org> | 2021-01-11 10:01:39 +0100 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2021-01-15 07:26:29 +0000 |
| commit | fdcdfceefdd3186ef0b70bb6e83dddc8f4c073db (patch) | |
| tree | 94bc0914f573c08d7881a741b79871dafce9848e /libcli | |
| parent | 63e6653be608d76a6f91795671cb19ef912811c1 (diff) | |
| download | samba-fdcdfceefdd3186ef0b70bb6e83dddc8f4c073db.tar.gz | |
libcli/smb: Change some checks to SMB_ASSERTS
If we end up here, it's definitely a programming error in the basic
parsing layer of the SMB2 packet.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14607
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Diffstat (limited to 'libcli')
| -rw-r--r-- | libcli/smb/smb2_signing.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/libcli/smb/smb2_signing.c b/libcli/smb/smb2_signing.c index 6ece5f2e4d3..b1e0253948f 100644 --- a/libcli/smb/smb2_signing.c +++ b/libcli/smb/smb2_signing.c @@ -189,13 +189,8 @@ NTSTATUS smb2_signing_check_pdu(struct smb2_signing_key *signing_key, static const uint8_t zero_sig[16] = { 0, }; int i; - if (count < 2) { - return NT_STATUS_INVALID_PARAMETER; - } - - if (vector[0].iov_len != SMB2_HDR_BODY) { - return NT_STATUS_INVALID_PARAMETER; - } + SMB_ASSERT(count >= 2); + SMB_ASSERT(vector[0].iov_len == SMB2_HDR_BODY); hdr = (const uint8_t *)vector[0].iov_base; |