diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2018-05-28 13:02:16 +1200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-06-26 09:19:16 +0200 |
| commit | d1b59c266b2076a286ff971769b9380c834c29ee (patch) | |
| tree | a4244b3238517689bad444dc369e708718e3c711 /lib | |
| parent | 5c1d9b0b9acd5f4a1d2030f23829183cbbeb072d (diff) | |
| download | samba-d1b59c266b2076a286ff971769b9380c834c29ee.tar.gz | |
ldb: Indicate that the ltdb_dn_list_sort() in list_union is a bit subtle.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 3632775d7ad31e06437ed76b8731d9895930caa1)
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/ldb/ldb_tdb/ldb_index.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/ldb/ldb_tdb/ldb_index.c b/lib/ldb/ldb_tdb/ldb_index.c index 674c5fc41f8..6da64cfa4ce 100644 --- a/lib/ldb/ldb_tdb/ldb_index.c +++ b/lib/ldb/ldb_tdb/ldb_index.c @@ -1120,6 +1120,9 @@ static bool list_union(struct ldb_context *ldb, /* * Sort the lists (if not in GUID DN mode) so we can do * the de-duplication during the merge + * + * NOTE: This can sort the in-memory index values, as list or + * list2 might not be a copy! */ ltdb_dn_list_sort(ltdb, list); ltdb_dn_list_sort(ltdb, list2); |