diff options
| author | Ralph Boehme <slow@samba.org> | 2018-12-23 09:44:22 +0100 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2019-01-11 23:11:14 +0100 |
| commit | 42e2ab7e9973e271cd7df4a1a22feaac1b8c0fd7 (patch) | |
| tree | efd94e41329dd24eb4388942492aec5ca9a260e0 /lib/pthreadpool | |
| parent | 7fd9bc3b6e51b818a0c2e39631f6667a993081ff (diff) | |
| download | samba-42e2ab7e9973e271cd7df4a1a22feaac1b8c0fd7.tar.gz | |
Revert "pthreadpool: add a comment about a further optimization in pthreadpool_tevent_job_destructor()"
This reverts commit f23cac39b36b026650e0922c78fe0fd3fe567e35.
See the discussion in
https://lists.samba.org/archive/samba-technical/2018-December/131731.html
for the reasoning behind this revert.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Diffstat (limited to 'lib/pthreadpool')
| -rw-r--r-- | lib/pthreadpool/pthreadpool_tevent.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/lib/pthreadpool/pthreadpool_tevent.c b/lib/pthreadpool/pthreadpool_tevent.c index 5ccff6231f0..a0e146b5467 100644 --- a/lib/pthreadpool/pthreadpool_tevent.c +++ b/lib/pthreadpool/pthreadpool_tevent.c @@ -493,23 +493,6 @@ static int pthreadpool_tevent_job_destructor(struct pthreadpool_tevent_job *job) } /* - * TODO?: We could further improve this by adjusting - * tevent_threaded_schedule_immediate_destructor() - * and allow TALLOC_FREE() during its time - * in the main_ev->scheduled_immediates list. - * - * PTHREAD_TEVENT_JOB_THREAD_FENCE(job); - * if (state->needs_fence.signaled) { - * * - * * The signal function is completed - * * in future we may be allowed - * * to call TALLOC_FREE(job->im). - * * - * TALLOC_FREE(job->im); - * } - */ - - /* * pthreadpool_tevent_job_orphan() already removed * it from pool->jobs. And we don't need try * pthreadpool_cancel_job() again. |