diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2019-11-22 10:06:57 +1300 |
|---|---|---|
| committer | Isaac Boukris <iboukris@sn-devel-184> | 2019-11-22 11:48:59 +0000 |
| commit | 6107c79c90fdff3fe60e0d0ef3efe57b52b21262 (patch) | |
| tree | c9c4d42768f075c5e9a3316ad889282c1ae7a2fe /lib/audit_logging | |
| parent | f8947538b5e445ab9c1931d1f7826771ee582385 (diff) | |
| download | samba-6107c79c90fdff3fe60e0d0ef3efe57b52b21262.tar.gz | |
build: Do not build selftest binaries for builds without --enable-selftest
Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()
This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.
Not modified are
- test_lp_load
- notifyd-tests
- gendrandperf
- test* from examples/libsmbclient
- dbwrap_torture
- split_tokens
- locktest2
- msgtest
- msg_sink
- msg_source
- versiontest
- rpc_open_tcp
- test_headers
As these are not tested in selftest so any change would also be
untested. Of course they probably should be added in a different
MR.
Also not modified (because they are not tests, nor part of the
build system) are:
- smb2mount
- notifydd
- log2pacp
- debug2html
- smbfilter
- destroy_netlogon_creds_cli
- spotlight2*
- tevent_glib_tracker
These do however appear to be untested.
For now, the source4 forked client tools are left unchanged:
- smbclient4
- nmblookup4
Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install. These are however tested.
The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
correct but are not needed if the selftest is not run on MacOS.
There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184
Diffstat (limited to 'lib/audit_logging')
| -rw-r--r-- | lib/audit_logging/wscript_build | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/audit_logging/wscript_build b/lib/audit_logging/wscript_build index 4811e056b72..125c94bad90 100644 --- a/lib/audit_logging/wscript_build +++ b/lib/audit_logging/wscript_build @@ -9,7 +9,7 @@ bld.SAMBA_SUBSYSTEM( source='audit_logging.c' ) -if bld.AD_DC_BUILD_IS_ENABLED() and bld.CONFIG_GET('ENABLE_SELFTEST'): +if bld.AD_DC_BUILD_IS_ENABLED(): bld.SAMBA_BINARY( 'audit_logging_test', source='tests/audit_logging_test.c', @@ -21,10 +21,10 @@ if bld.AD_DC_BUILD_IS_ENABLED() and bld.CONFIG_GET('ENABLE_SELFTEST'): samba-util LIBTSOCKET ''', - install=False + for_selftest=True ) -if bld.AD_DC_BUILD_IS_ENABLED() and bld.CONFIG_GET('ENABLE_SELFTEST'): +if bld.AD_DC_BUILD_IS_ENABLED(): bld.SAMBA_BINARY( 'audit_logging_error_test', source='tests/audit_logging_error_test.c', @@ -36,7 +36,7 @@ if bld.AD_DC_BUILD_IS_ENABLED() and bld.CONFIG_GET('ENABLE_SELFTEST'): samba-util LIBTSOCKET ''', - install=False, + for_selftest=True, ldflags=''' -Wl,--wrap,json_object_set_new -Wl,--wrap,json_object_update |