diff options
| author | Ralph Boehme <slow@samba.org> | 2020-10-02 17:29:58 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2020-10-02 21:00:05 +0000 |
| commit | 322574834f1e71bc01f21be9059ca4d386517c84 (patch) | |
| tree | 93f427036eb20da2df5ae30d186f3c16321a1fe6 /examples | |
| parent | 1c444f9c37c01f986cbe880f0a6d4abdd8c34a0b (diff) | |
| download | samba-322574834f1e71bc01f21be9059ca4d386517c84.tar.gz | |
vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()
This was supposed to be a shortcut to avoid passing dirfsp around as an explicit
function argument throughout the whole codebase when the new VFS design idea was
based on using *AT functions throughout the VFS.
Now that we've opted for basing the VFS on handles and *AT functions will only
be used in a much more limitted extent, it makes sense to remove this internal
dirfsp reference, otherwise the combination of internal fsp->dirfsp and
smb_fname->fsp is going to be a tough to wrap your head around.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct 2 21:00:05 UTC 2020 on sn-devel-184
Diffstat (limited to 'examples')
| -rw-r--r-- | examples/VFS/skel_opaque.c | 1 | ||||
| -rw-r--r-- | examples/VFS/skel_transparent.c | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/examples/VFS/skel_opaque.c b/examples/VFS/skel_opaque.c index 0a6ca4d9200..90ee82ab258 100644 --- a/examples/VFS/skel_opaque.c +++ b/examples/VFS/skel_opaque.c @@ -204,7 +204,6 @@ static int skel_openat(struct vfs_handle_struct *handle, static NTSTATUS skel_create_file(struct vfs_handle_struct *handle, struct smb_request *req, - struct files_struct **dirfsp, struct smb_filename *smb_fname, uint32_t access_mask, uint32_t share_access, diff --git a/examples/VFS/skel_transparent.c b/examples/VFS/skel_transparent.c index 677af2217bf..d48ac47443b 100644 --- a/examples/VFS/skel_transparent.c +++ b/examples/VFS/skel_transparent.c @@ -212,7 +212,6 @@ static int skel_openat(struct vfs_handle_struct *handle, static NTSTATUS skel_create_file(struct vfs_handle_struct *handle, struct smb_request *req, - struct files_struct **dirfsp, struct smb_filename *smb_fname, uint32_t access_mask, uint32_t share_access, @@ -231,7 +230,6 @@ static NTSTATUS skel_create_file(struct vfs_handle_struct *handle, { return SMB_VFS_NEXT_CREATE_FILE(handle, req, - dirfsp, smb_fname, access_mask, share_access, |