summaryrefslogtreecommitdiff
path: root/ctdb
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2017-02-23 11:31:32 +1100
committerStefan Metzmacher <metze@samba.org>2017-03-06 19:40:23 +0100
commitf9755bf200b5565474a55bca800dfff1a07c0d0a (patch)
tree5a279774d5c2eca9276fc8c49f9804fe915d5ea0 /ctdb
parent888f433f993e42020f27ed09535c91bced14640b (diff)
downloadsamba-f9755bf200b5565474a55bca800dfff1a07c0d0a.tar.gz
ctdb-logging: CID 1396883 Dereference null return value (NULL_RETURNS)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592 The fix in 08e03fa7f5fdc7f988fbbb26929e8c5727f36c2e is incomplete. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 55b75e4ecec17fdb741c12ad5a22846f77f71215)
Diffstat (limited to 'ctdb')
-rw-r--r--ctdb/common/logging.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ctdb/common/logging.c b/ctdb/common/logging.c
index c8ccf26b565..8e547c97d9d 100644
--- a/ctdb/common/logging.c
+++ b/ctdb/common/logging.c
@@ -522,6 +522,7 @@ int logging_init(TALLOC_CTX *mem_ctx, const char *logging,
name = strtok(str, ":");
if (name == NULL) {
+ talloc_free(str);
return EINVAL;
}
option = strtok(NULL, ":");