diff options
| author | Amitay Isaacs <amitay@gmail.com> | 2019-05-13 17:07:59 +1000 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2019-05-14 08:59:03 +0000 |
| commit | b1f4c86eea022999d5439e4a6ef3494fe41479b6 (patch) | |
| tree | b01dbce2d10b5c0470818ae1e7247bcb6b6e8440 /ctdb | |
| parent | 30bc6e2529cdd444d4ec7902844c3a6fb0858090 (diff) | |
| download | samba-b1f4c86eea022999d5439e4a6ef3494fe41479b6.tar.gz | |
ctdb-common: Fix memory leak in run_proc
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue May 14 08:59:03 UTC 2019 on sn-devel-184
Diffstat (limited to 'ctdb')
| -rw-r--r-- | ctdb/common/run_proc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ctdb/common/run_proc.c b/ctdb/common/run_proc.c index 037b6d9651d..0c3c1de72fe 100644 --- a/ctdb/common/run_proc.c +++ b/ctdb/common/run_proc.c @@ -302,13 +302,15 @@ again: proc->fd = -1; } + DLIST_REMOVE(run_ctx->plist, proc); + /* Active run_proc request */ if (proc->req != NULL) { run_proc_done(proc->req); + } else { + talloc_free(proc); } - DLIST_REMOVE(run_ctx->plist, proc); - goto again; } @@ -426,6 +428,7 @@ static void run_proc_done(struct tevent_req *req) if (state->proc->output != NULL) { state->output = talloc_steal(state, state->proc->output); } + talloc_steal(state, state->proc); tevent_req_done(req); } |