diff options
author | Martin Schwenke <martin@meltin.net> | 2019-05-11 14:24:24 +1000 |
---|---|---|
committer | Karolin Seeger <kseeger@samba.org> | 2019-05-17 07:18:32 +0000 |
commit | 76c7302105c6f016d5c63315a685746396a789f4 (patch) | |
tree | 31e42676f050a7777681116709b0b85a51abbf13 /ctdb | |
parent | f81a971cc299a235cd2698c035f3ca10b24735e1 (diff) | |
download | samba-76c7302105c6f016d5c63315a685746396a789f4.tar.gz |
ctdb-recoverd: Fix memory leak
state is always freed before exiting this function, so allocate fde
off it instead of long-lived ctdb context.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 6a2941e2a9fd6ab2d5b8dbac042b61a7b1b0b914)
Diffstat (limited to 'ctdb')
-rw-r--r-- | ctdb/server/ctdb_recoverd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_recoverd.c b/ctdb/server/ctdb_recoverd.c index 469fd21b463..88ef3b1c5a0 100644 --- a/ctdb/server/ctdb_recoverd.c +++ b/ctdb/server/ctdb_recoverd.c @@ -1135,7 +1135,7 @@ static int helper_run(struct ctdb_recoverd *rec, TALLOC_CTX *mem_ctx, state->done = false; - fde = tevent_add_fd(rec->ctdb->ev, rec->ctdb, state->fd[0], + fde = tevent_add_fd(rec->ctdb->ev, state, state->fd[0], TEVENT_FD_READ, helper_handler, state); if (fde == NULL) { goto fail; |