summaryrefslogtreecommitdiff
path: root/ctdb
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2022-07-05 19:33:15 +1000
committerAmitay Isaacs <amitay@samba.org>2022-07-28 09:02:08 +0000
commit3efa56aa61da952f869f43188b0d53a11c820ca0 (patch)
tree44d699d3f519b46722c68cba1c1afb6894770de4 /ctdb
parentffa84f2e5d335626b5f7311af8d2a7056b3e5c6f (diff)
downloadsamba-3efa56aa61da952f869f43188b0d53a11c820ca0.tar.gz
ctdb-daemon: Fix printing of tickle ACKs
Commit f5a20377347aba18700d010d4201775fc83a0b1b arguably got this back-to-front: 2022-07-27T09:50:01.985857+10:00 testn1 ctdbd[17820]: ../../ctdb/server/ctdb_takeover.c:514 sending TAKE_IP for '10.0.1.173' 2022-07-27T09:50:01.990601+10:00 testn1 ctdbd[17820]: Send TCP tickle ACK: 10.0.1.77:33004 -> 10.0.1.173:2049 2022-07-27T09:50:01.991323+10:00 testn1 ctdb-takeover[19758]: TAKEOVER_IP 10.0.1.173 succeeded on node 0 Unfortunately there is an inconsistency somewhere in the connection tracking code used for tickle ACKs, making this less than obvious. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Thu Jul 28 09:02:08 UTC 2022 on sn-devel-184
Diffstat (limited to 'ctdb')
-rw-r--r--ctdb/server/ctdb_takeover.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_takeover.c b/ctdb/server/ctdb_takeover.c
index 0fb8076ad55..4d2d0416752 100644
--- a/ctdb/server/ctdb_takeover.c
+++ b/ctdb/server/ctdb_takeover.c
@@ -402,7 +402,7 @@ static void ctdb_control_send_arp(struct tevent_context *ev,
ret = ctdb_connection_to_buf(buf,
sizeof(buf),
tcon,
- true,
+ false,
" -> ");
if (ret != 0) {
strlcpy(buf, "UNKNOWN", sizeof(buf));