summaryrefslogtreecommitdiff
path: root/ctdb
diff options
context:
space:
mode:
authorAmitay Isaacs <amitay@gmail.com>2018-06-06 15:47:13 +0200
committerKarolin Seeger <kseeger@samba.org>2020-03-30 10:08:24 +0000
commit30d8a00c8e8a1536b043ddecb0cdd46cbc523bbe (patch)
treeacdfaf184a6bddedddd975193b78aac7b3206a06 /ctdb
parent1d73ad17ec60bb585816f9915497b00134e1b85a (diff)
downloadsamba-30d8a00c8e8a1536b043ddecb0cdd46cbc523bbe.tar.gz
ctdb-daemon: Avoid memory leak when packet is deferred
Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 680df07630a94b3e76edefe98ee0986e7e5e1f12)
Diffstat (limited to 'ctdb')
-rw-r--r--ctdb/server/ctdb_server.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_server.c b/ctdb/server/ctdb_server.c
index 4b4c2e9896f..1470b00dba5 100644
--- a/ctdb/server/ctdb_server.c
+++ b/ctdb/server/ctdb_server.c
@@ -374,8 +374,9 @@ static void ctdb_defer_packet(struct ctdb_context *ctdb, struct ctdb_req_header
return;
}
q->ctdb = ctdb;
- q->hdr = talloc_memdup(ctdb, hdr, hdr->length);
+ q->hdr = talloc_memdup(q, hdr, hdr->length);
if (q->hdr == NULL) {
+ talloc_free(q);
DEBUG(DEBUG_ERR,("Error copying deferred packet to self\n"));
return;
}