diff options
| author | Martin Schwenke <martin@meltin.net> | 2019-06-24 16:45:06 +1000 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2019-07-05 05:03:24 +0000 |
| commit | ba95cb2ae1564edc27541c2a87e35f338e4653f7 (patch) | |
| tree | 9f479dd4c7d1869e8c169ebb2f8f509dd0f3c994 /ctdb | |
| parent | 5527f3922fd680a9bd8330434a0c4221f35e51aa (diff) | |
| download | samba-ba95cb2ae1564edc27541c2a87e35f338e4653f7.tar.gz | |
ctdb-event: Fix signed/unsigned comparisons by casting
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Diffstat (limited to 'ctdb')
| -rw-r--r-- | ctdb/event/event_conf.c | 2 | ||||
| -rw-r--r-- | ctdb/event/event_tool.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ctdb/event/event_conf.c b/ctdb/event/event_conf.c index 33bfc7c5335..61ecf8e33eb 100644 --- a/ctdb/event/event_conf.c +++ b/ctdb/event/event_conf.c @@ -50,7 +50,7 @@ static bool event_conf_validate_debug_script(const char *key, "%s/%s", path_etcdir(), basename(script)); - if (ret >= sizeof(script_path)) { + if (ret < 0 || (size_t)ret >= sizeof(script_path)) { D_ERR("debug script path too long\n"); return false; } diff --git a/ctdb/event/event_tool.c b/ctdb/event/event_tool.c index 6cc5dc9a822..9c95e6d9553 100644 --- a/ctdb/event/event_tool.c +++ b/ctdb/event/event_tool.c @@ -408,7 +408,7 @@ static int event_command_script_list(TALLOC_CTX *mem_ctx, } len = readlink(e->path, buf, sizeof(buf)); - if (len == -1 || len >= sizeof(buf)) { + if (len == -1 || (size_t)len >= sizeof(buf)) { /* * Not a link? Disappeared? Invalid * link target? Something else? |