diff options
| author | Martin Schwenke <martin@meltin.net> | 2019-06-21 16:08:58 +1000 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2019-07-05 05:03:23 +0000 |
| commit | 75747c6106fa2a966686f7a523cdb9d28708b870 (patch) | |
| tree | ed28cfa28846f970d8e70f93ae96c3f119561e0b /ctdb | |
| parent | d855dc2a5faff1eafec287fa8748000d21949684 (diff) | |
| download | samba-75747c6106fa2a966686f7a523cdb9d28708b870.tar.gz | |
ctdb-tests: Avoid warning about NULL dereference
Static analysis finds that earlier in the call path, ctdb_string_len()
checks for NULL, so complains that a NULL value can be passed to
strlen() here. Avoid this by adding an assert().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Diffstat (limited to 'ctdb')
| -rw-r--r-- | ctdb/tests/src/protocol_types_compat_test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ctdb/tests/src/protocol_types_compat_test.c b/ctdb/tests/src/protocol_types_compat_test.c index 0f1e548d099..59aef825b72 100644 --- a/ctdb/tests/src/protocol_types_compat_test.c +++ b/ctdb/tests/src/protocol_types_compat_test.c @@ -838,6 +838,7 @@ static size_t ctdb_var_list_len_old(struct ctdb_var_list *in) size_t len = sizeof(uint32_t); for (i=0; i<in->count; i++) { + assert(in->var[i] != NULL); len += strlen(in->var[i]) + 1; } return len; |