diff options
| author | Martin Schwenke <martin@meltin.net> | 2018-09-05 12:42:07 +1000 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2018-09-06 08:33:59 +0200 |
| commit | bc62182ff46023494f710a78d5a57a7baffa8780 (patch) | |
| tree | ff42da74266cfc4b19bf7264728c31396ac5eb0d /ctdb/tests/src | |
| parent | 05862b7bb0e62ba500b68cfc3403a85b00aa61dc (diff) | |
| download | samba-bc62182ff46023494f710a78d5a57a7baffa8780.tar.gz | |
ctdb-tests: Check result of write() in ARP and TCP tests
CTDB -O3 --picky-developer build is failing. Not sure how this
slipped through.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Sep 6 08:33:59 CEST 2018 on sn-devel-144
Diffstat (limited to 'ctdb/tests/src')
| -rw-r--r-- | ctdb/tests/src/system_socket_test.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/ctdb/tests/src/system_socket_test.c b/ctdb/tests/src/system_socket_test.c index 6dd9e432ef7..f7d0c7c7701 100644 --- a/ctdb/tests/src/system_socket_test.c +++ b/ctdb/tests/src/system_socket_test.c @@ -59,6 +59,7 @@ static void test_arp(const char *addr_str, const char *hwaddr_str, bool reply) uint8_t buf[512]; size_t buflen = sizeof(buf); size_t len; + ssize_t num_written; int ret; ret = ctdb_sock_addr_from_string(addr_str, &addr, false); @@ -80,7 +81,8 @@ static void test_arp(const char *addr_str, const char *hwaddr_str, bool reply) assert(ret == 0); - write(STDOUT_FILENO, buf, len); + num_written = write(STDOUT_FILENO, buf, len); + assert(num_written == len); } #else /* HAVE_PACKETSOCKET */ @@ -104,6 +106,7 @@ static void test_tcp(const char *src_str, uint8_t buf[512]; struct ether_header *eth; size_t expected_len, len; + ssize_t num_written; char src_str_out[64], dst_str_out[64]; uint32_t seq_out, ack_out; int rst_out; @@ -156,7 +159,10 @@ static void test_tcp(const char *src_str, assert(ret == 0); assert(len == expected_len); - write(STDOUT_FILENO, buf + sizeof(struct ether_header), len); + num_written = write(STDOUT_FILENO, + buf + sizeof(struct ether_header), + len); + assert(num_written == len); switch (ntohs(eth->ether_type)) { case ETHERTYPE_IP: |