diff options
| author | Sumit Bose <sbose@redhat.com> | 2011-08-10 17:53:56 +0200 |
|---|---|---|
| committer | Amitay Isaacs <amitay@gmail.com> | 2013-07-11 15:16:55 +1000 |
| commit | 157f1cfefd898aa7fb3dc67796565e4d5ad3d37c (patch) | |
| tree | 69c2e111284d2850afd15b495ed9c2c403d90509 /ctdb/server/ctdb_logging.c | |
| parent | d039f799ac426c903289800edc8febabe5bec49d (diff) | |
| download | samba-157f1cfefd898aa7fb3dc67796565e4d5ad3d37c.tar.gz | |
Fixes for various issues found by Coverity
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 05bfdbbd0d4abdfbcf28e3930086723508b35952)
Diffstat (limited to 'ctdb/server/ctdb_logging.c')
| -rw-r--r-- | ctdb/server/ctdb_logging.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ctdb/server/ctdb_logging.c b/ctdb/server/ctdb_logging.c index adf1c8f2ba6..218186e7f04 100644 --- a/ctdb/server/ctdb_logging.c +++ b/ctdb/server/ctdb_logging.c @@ -547,6 +547,10 @@ int ctdb_set_child_logging(struct ctdb_context *ctdb) /* We'll fail if stderr/stdout not already open; it's simpler. */ old_stdout = dup(STDOUT_FILENO); old_stderr = dup(STDERR_FILENO); + if (old_stdout < 0 || old_stderr < 0) { + DEBUG(DEBUG_ERR, ("Failed to dup stdout/stderr for child logging\n")); + return -1; + } if (dup2(p[1], STDOUT_FILENO) < 0 || dup2(p[1], STDERR_FILENO) < 0) { int saved_errno = errno; dup2(old_stdout, STDOUT_FILENO); |