summaryrefslogtreecommitdiff
path: root/auth/credentials
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2018-04-04 10:26:14 +0200
committerJeremy Allison <jra@samba.org>2018-04-05 01:10:09 +0200
commit90c02ec64d0e3c860f8d6906cf849bdd2c7bcc54 (patch)
tree33d5518476f2514d07ae21031fc6bd7a84f27309 /auth/credentials
parente895b6cf4a7eb3d50d618a022be74db85975bf69 (diff)
downloadsamba-90c02ec64d0e3c860f8d6906cf849bdd2c7bcc54.tar.gz
credentials: Fix CID 1414796 Explicit null dereferenced
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'auth/credentials')
-rw-r--r--auth/credentials/credentials_secrets.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/auth/credentials/credentials_secrets.c b/auth/credentials/credentials_secrets.c
index ae1d23b51c1..25c1fddf2ec 100644
--- a/auth/credentials/credentials_secrets.c
+++ b/auth/credentials/credentials_secrets.c
@@ -106,6 +106,11 @@ static NTSTATUS cli_credentials_set_secrets_lct(struct cli_credentials *cred,
}
password = ldb_msg_find_attr_as_string(msg, "secret", NULL);
+ if (password == NULL) {
+ /* This attribute is mandatory */
+ talloc_free(mem_ctx);
+ return NT_STATUS_NOT_FOUND;
+ }
whenChanged = ldb_msg_find_ldb_val(msg, "whenChanged");
if (!whenChanged || ldb_val_to_time(whenChanged, &lct) != LDB_SUCCESS) {