diff options
| author | Volker Lendecke <vl@samba.org> | 2019-05-27 11:24:14 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2019-11-13 00:20:55 +0000 |
| commit | 3fea05e01f845588eb0de63af435bfec670593be (patch) | |
| tree | 91f3d63cf87fddc636b10af9095306fdbaba6beb /WHATSNEW.txt | |
| parent | a0aaf5c3345239959221d6c2e9cd949b8ccdf233 (diff) | |
| download | samba-3fea05e01f845588eb0de63af435bfec670593be.tar.gz | |
smbd: Remove write cache
Since this was written, our write path has changed significantly. In
particular we have gained very flexible support for async I/O, with the
linux io_uring in the pipeline. Caching stuff in main memory and then
doing a blocking pwrite nowadays does not belong into the core smbd
code. If someone wants it back, it should be doable in a VFS module.
Removes: "write cache size" parameter.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184
Diffstat (limited to 'WHATSNEW.txt')
| -rw-r--r-- | WHATSNEW.txt | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/WHATSNEW.txt b/WHATSNEW.txt index dccb44dbd27..cc43b29b3d1 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -56,6 +56,23 @@ applies. REMOVED FEATURES ================ +The smb.conf parameter "write cache size" has been removed. + +Since the in-memory write caching code was written, our write path has +changed significantly. In particular we have gained very flexible +support for async I/O, with the new linux io_uring interface in +development. The old write cache concept which cached data in main +memory followed by a blocking pwrite no longer gives any improvement +on modern systems, and may make performance worse on memory-contrained +systems, so this functionality should not be enabled in core smbd +code. + +In addition, it complicated the write code, which is a performance +critical code path. + +If required for specialist purposes, it can be recreated as a VFS +module. + BIND9_FLATFILE deprecated ------------------------- @@ -77,6 +94,7 @@ smb.conf changes nfs4:acedup Changed default merge rndc command Removed + write cache size Removed KNOWN ISSUES ============ |