summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2018-08-28 16:30:17 +0200
committerStefan Metzmacher <metze@samba.org>2018-09-05 13:35:25 +0200
commitf77ea3554e3a94afd3ceb4e06829ba5d89bc9d28 (patch)
treee9eefa371fb1927d4120506ff13396aa2a08a818
parentf73ef3564f701b26143130823cfb72bb7d06fabb (diff)
downloadsamba-f77ea3554e3a94afd3ceb4e06829ba5d89bc9d28.tar.gz
s4:rpc_server/netlogon: make use of talloc_zero_array() for the netr_OneDomainInfo array
It's much safer than having uninitialized memory when we hit an error case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ef0b489ad0d93199e08415dd895da5cfe2d1c11a)
-rw-r--r--source4/rpc_server/netlogon/dcerpc_netlogon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index 71ab942ae9b..12d6bcd14c2 100644
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -2349,7 +2349,7 @@ static NTSTATUS dcesrv_netr_LogonGetDomainInfo(struct dcesrv_call_state *dce_cal
}
domain_info->trusted_domain_count = ret3 + 1;
- domain_info->trusted_domains = talloc_array(mem_ctx,
+ domain_info->trusted_domains = talloc_zero_array(mem_ctx,
struct netr_OneDomainInfo,
domain_info->trusted_domain_count);
NT_STATUS_HAVE_NO_MEMORY(domain_info->trusted_domains);