summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRalph Boehme <slow@samba.org>2018-08-30 15:57:33 +0200
committerStefan Metzmacher <metze@samba.org>2018-09-05 13:35:28 +0200
commit0e8298e565657feee4fedec9e029d51504b903d8 (patch)
tree4f9b0eabb1b997145973b4d30afeec777ba7d070
parentb7c659a4499dc7b62423ce930f7ce2128eded90e (diff)
downloadsamba-0e8298e565657feee4fedec9e029d51504b903d8.tar.gz
s3:smbd: add a comment stating that file_close_user() is redundant for SMB2
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Sep 1 01:26:35 CEST 2018 on sn-devel-144 (cherry picked from commit 5d95f79f604d90c2646225a0f2470f05dd71e19e)
-rw-r--r--source3/smbd/smbXsrv_session.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/source3/smbd/smbXsrv_session.c b/source3/smbd/smbXsrv_session.c
index 7fe385c2047..5780b7956c9 100644
--- a/source3/smbd/smbXsrv_session.c
+++ b/source3/smbd/smbXsrv_session.c
@@ -1652,6 +1652,12 @@ NTSTATUS smbXsrv_session_logoff(struct smbXsrv_session *session)
session->status = NT_STATUS_USER_SESSION_DELETED;
if (session->compat) {
+ /*
+ * For SMB2 this is a bit redundant as files are also close
+ * below via smb2srv_tcon_disconnect_all() -> ... ->
+ * smbXsrv_tcon_disconnect() -> close_cnum() ->
+ * file_close_conn().
+ */
file_close_user(sconn, session->compat->vuid);
}