diff options
| author | Stefan Metzmacher <metze@samba.org> | 2021-02-09 13:48:36 +0100 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2021-02-16 21:35:14 +0000 |
| commit | 6382ca8568219a1ba54bc05d24ccbff019240cfe (patch) | |
| tree | 370ad75889a7379b0b6cdb1c77d60205b5289355 | |
| parent | e80ef35f9356eadcaf6578a5b2c8d68acc45c172 (diff) | |
| download | samba-6382ca8568219a1ba54bc05d24ccbff019240cfe.tar.gz | |
s3:pysmbd: fix fd leak in py_smbd_create_file()
Various 'samba-tool domain backup' commands use this and will
fail if there's over ~1000 files in the sysvol folder.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13898
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit d8fa464a2dfb11df4e1db4ebffe8bd28ff118c75)
| -rw-r--r-- | source3/smbd/pysmbd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/source3/smbd/pysmbd.c b/source3/smbd/pysmbd.c index 39fe875a385..58c96396e08 100644 --- a/source3/smbd/pysmbd.c +++ b/source3/smbd/pysmbd.c @@ -1113,9 +1113,12 @@ static PyObject *py_smbd_create_file(PyObject *self, PyObject *args, PyObject *k if (!NT_STATUS_IS_OK(status)) { DBG_ERR("init_files_struct failed: %s\n", nt_errstr(status)); + } else if (fsp != NULL) { + SMB_VFS_CLOSE(fsp); } TALLOC_FREE(frame); + PyErr_NTSTATUS_NOT_OK_RAISE(status); Py_RETURN_NONE; } |