summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGarming Sam <garming@catalyst.net.nz>2016-01-28 12:36:43 +1300
committerKarolin Seeger <kseeger@samba.org>2016-02-24 11:43:59 +0100
commit74fc257badc81bf63c1f3174a6eb3bf0067e07bf (patch)
tree51529f927cd1b39ec7f4036d8d209cd180eb02f2
parent1a97ee31a8702ed7b06d0b07355615e314d29106 (diff)
downloadsamba-74fc257badc81bf63c1f3174a6eb3bf0067e07bf.tar.gz
CVE-2016-0771: dnsserver: don't force UTF-8 for TXT
While using a charset is not entirely logical, it allows testing of non UTF-8 data (like inserting 0xFF into the TXT string). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11128 BUG: https://bugzilla.samba.org/show_bug.cgi?id=11686 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--librpc/idl/dnsserver.idl2
1 files changed, 1 insertions, 1 deletions
diff --git a/librpc/idl/dnsserver.idl b/librpc/idl/dnsserver.idl
index 506d72ef769..d567ec9e38e 100644
--- a/librpc/idl/dnsserver.idl
+++ b/librpc/idl/dnsserver.idl
@@ -73,7 +73,7 @@ import "misc.idl", "dnsp.idl";
typedef [public,gensize] struct {
[value(strlen(str))] uint8 len;
- [charset(UTF8)] uint8 str[len];
+ [charset(UNIX)] uint8 str[len];
}
DNS_RPC_NAME;