diff options
author | Jeremy Allison <jra@samba.org> | 2013-10-08 15:01:38 -0700 |
---|---|---|
committer | Karolin Seeger <kseeger@samba.org> | 2013-10-14 10:09:30 +0200 |
commit | 63f370bdbad94d6aba7a4783d4238fcfc524b055 (patch) | |
tree | aab11ae482036e7c482878bf476caeb66fcd506d | |
parent | ee0ef2a5b4b06fdb723a5232f90212fda5e853d1 (diff) | |
download | samba-63f370bdbad94d6aba7a4783d4238fcfc524b055.tar.gz |
Fix bug #10187 - Missing talloc_free can leak stackframe in error path.
Fix error path.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Oct 9 03:50:56 CEST 2013 on sn-devel-104
-rw-r--r-- | source3/winbindd/winbindd_msrpc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c index b14a4f87c38..b426884e896 100644 --- a/source3/winbindd/winbindd_msrpc.c +++ b/source3/winbindd/winbindd_msrpc.c @@ -944,8 +944,9 @@ static NTSTATUS msrpc_trusted_domains(struct winbindd_domain *domain, } status = cm_connect_lsa(domain, tmp_ctx, &lsa_pipe, &lsa_policy); - if (!NT_STATUS_IS_OK(status)) - return status; + if (!NT_STATUS_IS_OK(status)) { + goto done; + } status = rpc_trusted_domains(tmp_ctx, lsa_pipe, |