diff options
| author | Jeremy Allison <jra@samba.org> | 2013-10-08 15:01:38 -0700 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2013-11-28 10:13:41 +0100 |
| commit | b8da65a8b777a449e9ead8bfc55c98ac60384b91 (patch) | |
| tree | 69da1593feed48f399f2230e0d43f891b17cdd08 | |
| parent | a70e6b944455c2c24319cc68b8cb15746a469640 (diff) | |
| download | samba-b8da65a8b777a449e9ead8bfc55c98ac60384b91.tar.gz | |
Fix bug #10187 - Missing talloc_free can leak stackframe in error path.
Fix error path.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Oct 9 03:50:56 CEST 2013 on sn-devel-104
(cherry picked from commit 63f370bdbad94d6aba7a4783d4238fcfc524b055)
| -rw-r--r-- | source3/winbindd/winbindd_msrpc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c index b14a4f87c38..b426884e896 100644 --- a/source3/winbindd/winbindd_msrpc.c +++ b/source3/winbindd/winbindd_msrpc.c @@ -944,8 +944,9 @@ static NTSTATUS msrpc_trusted_domains(struct winbindd_domain *domain, } status = cm_connect_lsa(domain, tmp_ctx, &lsa_pipe, &lsa_policy); - if (!NT_STATUS_IS_OK(status)) - return status; + if (!NT_STATUS_IS_OK(status)) { + goto done; + } status = rpc_trusted_domains(tmp_ctx, lsa_pipe, |