summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKai Blin <kai@samba.org>2013-01-18 23:11:07 +0100
committerKarolin Seeger <kseeger@samba.org>2013-01-29 10:52:01 +0100
commite9cd10049e0b5c1e24e454cc3277eb4bea033dfb (patch)
tree2f2b974fd3be4a4a56389801ad64049ee1c99f5d
parent4f0de0faf15e2c157ad88800a11648c181d82b65 (diff)
downloadsamba-e9cd10049e0b5c1e24e454cc3277eb4bea033dfb.tar.gz
swat: Use X-Frame-Options header to avoid clickjacking
Jann Horn reported a potential clickjacking vulnerability in SWAT where the SWAT page could be embedded into an attacker's page using a frame or iframe and then used to trick the user to change Samba settings. Avoid this by telling the browser to refuse the frame embedding via the X-Frame-Options: DENY header. Signed-off-by: Kai Blin <kai@samba.org> Fix bug #9576 - CVE-2013-0213: Clickjacking issue in SWAT.
-rw-r--r--source3/web/swat.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/web/swat.c b/source3/web/swat.c
index 754e3cee732..d2bbee40c34 100644
--- a/source3/web/swat.c
+++ b/source3/web/swat.c
@@ -260,7 +260,8 @@ static void print_header(void)
if (!cgi_waspost()) {
printf("Expires: 0\r\n");
}
- printf("Content-type: text/html\r\n\r\n");
+ printf("Content-type: text/html\r\n");
+ printf("X-Frame-Options: DENY\r\n\r\n");
if (!include_html("include/header.html")) {
printf("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 3.2//EN\">\n");