diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2015-05-07 14:26:33 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2015-06-12 06:57:16 +0200 |
| commit | 68a0f131fb5adc48e9c1a49dede696cacf358d76 (patch) | |
| tree | 81e54436bfa2efa560c6181f845b5f6d3a448d03 | |
| parent | af1a307f8d6d1d6b721ed4803a9d9ad08faa7e53 (diff) | |
| download | samba-68a0f131fb5adc48e9c1a49dede696cacf358d76.tar.gz | |
KCC: remove XXX scare comments around guid comparisons.
The guid comparisons are settled. We use ndrpack.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| -rw-r--r-- | python/samba/kcc/__init__.py | 1 | ||||
| -rw-r--r-- | python/samba/kcc/graph.py | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/python/samba/kcc/__init__.py b/python/samba/kcc/__init__.py index eae2bae861b..e1bdd587a22 100644 --- a/python/samba/kcc/__init__.py +++ b/python/samba/kcc/__init__.py @@ -507,7 +507,6 @@ class KCC(object): if s2_dnstr != s_dnstr: continue - #XXX GUID comparison lesser = (cn_conn.whenCreated < cn2_conn.whenCreated or (cn_conn.whenCreated == cn2_conn.whenCreated and packed_guid < ndr_pack(cn2_conn.guid))) diff --git a/python/samba/kcc/graph.py b/python/samba/kcc/graph.py index 83555c214a8..f3dc37348e4 100644 --- a/python/samba/kcc/graph.py +++ b/python/samba/kcc/graph.py @@ -514,7 +514,6 @@ def add_int_edge(graph, internal_edges, examine, v1, v2): newIntEdge = InternalEdge(root1, root2, red_red, ri2, examine.con_type, examine.site_link) # Order by vertex guid - #XXX guid comparison using ndr_pack if newIntEdge.v1.ndrpacked_guid > newIntEdge.v2.ndrpacked_guid: newIntEdge.v1 = root2 newIntEdge.v2 = root1 @@ -775,7 +774,6 @@ class InternalEdge(object): if self_time != other_time: return self_time > other_time - #XXX guid comparison using ndr_pack if self.v1.guid != other.v1.guid: return self.v1.ndrpacked_guid < other.v1.ndrpacked_guid |