summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristof Schmitt <cs@samba.org>2019-06-25 15:21:06 -0700
committerKarolin Seeger <kseeger@samba.org>2019-08-26 10:23:27 +0000
commit1026680518de4cf66f7c202536d0e555ec608e1d (patch)
tree51a0db2fa48bc649609c246f2007315eb94ecca8
parent2493a9f81b92df55c5e4c4f71c3635e3fedd445e (diff)
downloadsamba-1026680518de4cf66f7c202536d0e555ec608e1d.tar.gz
nfs4_acls: Use correct type when checking ownerGID
uid and gid are members of the same union so this makes no difference, but for type correctness and readability use the gid to check for ownerGID. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 3b3d722ce579c19c7b08d06a3adea275537545dc)
-rw-r--r--source3/modules/nfs4_acls.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
index f8861e9058b..b2ba4d1d701 100644
--- a/source3/modules/nfs4_acls.c
+++ b/source3/modules/nfs4_acls.c
@@ -856,7 +856,7 @@ static int smbacl4_substitute_simple(
if (!(ace->flags & SMB_ACE4_ID_SPECIAL) &&
ace->aceFlags & SMB_ACE4_IDENTIFIER_GROUP &&
- ace->who.uid == ownerGID &&
+ ace->who.gid == ownerGID &&
!(ace->aceFlags & SMB_ACE4_INHERIT_ONLY_ACE) &&
!(ace->aceFlags & SMB_ACE4_FILE_INHERIT_ACE) &&
!(ace->aceFlags & SMB_ACE4_DIRECTORY_INHERIT_ACE)) {