summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2013-11-05 06:31:29 +1100
committerVolker Lendecke <vl@samba.org>2013-11-20 12:19:59 +0100
commit3f77bf2ce318b51547c36f315b34a062ba7afccf (patch)
treeb9bbbad71da4b48c6f4e99896fab6586201ca024
parentc7762042ba43567b331fd42aec6abd77744ff486 (diff)
downloadsamba-3f77bf2ce318b51547c36f315b34a062ba7afccf.tar.gz
testparm: Warnings should not cause failure
Remove the return code of 1 associated with some warnings. Warnings should not cause failure. If any of these cases should cause a failure then they should be changed to errors. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Nov 20 12:19:59 CET 2013 on sn-devel-104
-rw-r--r--source3/utils/testparm.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index 1c13b52565c..ce853539932 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -86,7 +86,6 @@ static int do_global_checks(void)
if (strequal(lp_workgroup(), lp_netbios_name())) {
fprintf(stderr, "WARNING: 'workgroup' and 'netbios name' "
"must differ.\n\n");
- ret = 1;
}
if (!directory_exist_stat(lp_lockdir(), &st)) {
@@ -97,7 +96,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: lock directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_lockdir());
- ret = 1;
}
if (!directory_exist_stat(lp_statedir(), &st)) {
@@ -108,7 +106,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: state directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_statedir());
- ret = 1;
}
if (!directory_exist_stat(lp_cachedir(), &st)) {
@@ -119,7 +116,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: cache directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_cachedir());
- ret = 1;
}
if (!directory_exist_stat(lp_piddir(), &st)) {