diff options
| author | Stefan Metzmacher <metze@samba.org> | 2019-04-26 14:31:46 +0000 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2019-06-21 07:56:17 +0000 |
| commit | 29e402f583b520c25f355318b2868befac99fa9c (patch) | |
| tree | a9c3b48ac36f20519c6b6fef3d85fbb8ff4ce419 | |
| parent | 11b1f405ee9d41abf7d801494dbee3d8efc8935d (diff) | |
| download | samba-29e402f583b520c25f355318b2868befac99fa9c.tar.gz | |
dsdb:audit_log: avoid printing "... remote host [Unknown] SID [(NULL SID)] ..."
We better print "... remote host [Unknown] SID [S-1-5-18] ..."
in 'dsdb_audit' message, this matches what we print for
'dsdb_json_audit'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13916
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 706aba5bf62e674ae12786f6ab275752b8714464)
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/audit_log.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/audit_log.c b/source4/dsdb/samdb/ldb_modules/audit_log.c index 16acf146194..cfa06682002 100644 --- a/source4/dsdb/samdb/ldb_modules/audit_log.c +++ b/source4/dsdb/samdb/ldb_modules/audit_log.c @@ -884,6 +884,7 @@ static char *operation_human_readable( { struct ldb_context *ldb = NULL; const char *remote_host = NULL; + const struct tsocket_address *remote = NULL; const struct dom_sid *sid = NULL; const char *user_sid = NULL; const char *timestamp = NULL; @@ -898,7 +899,8 @@ static char *operation_human_readable( ldb = ldb_module_get_ctx(module); remote_host = dsdb_audit_get_remote_host(ldb, ctx); - if (remote_host != NULL && dsdb_audit_is_system_session(module)) { + remote = dsdb_audit_get_remote_address(ldb); + if (remote != NULL && dsdb_audit_is_system_session(module)) { sid = dsdb_audit_get_actual_sid(ldb); } else { sid = dsdb_audit_get_user_sid(module); |