summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2015-07-07 13:05:01 +0200
committerStefan Metzmacher <metze@samba.org>2016-04-12 19:25:31 +0200
commitf8aa62d6979e39f796eede866633c78e3f01fa0c (patch)
treeeea709966625377c9188d216cc53f9923e48724a
parentb4e38e29e88998bdabd669581dc6b74b58195c0f (diff)
downloadsamba-f8aa62d6979e39f796eede866633c78e3f01fa0c.tar.gz
CVE-2015-5370: s3:rpc_server: don't allow auth3 if the authentication was already finished
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
-rw-r--r--source3/rpc_server/srv_pipe.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/source3/rpc_server/srv_pipe.c b/source3/rpc_server/srv_pipe.c
index ea9d50d8a57..2926f06d5f8 100644
--- a/source3/rpc_server/srv_pipe.c
+++ b/source3/rpc_server/srv_pipe.c
@@ -860,8 +860,15 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
DEBUG(5, ("api_pipe_bind_auth3: decode request. %d\n", __LINE__));
+ /* We can only finish if the pipe is unbound for now */
+ if (p->pipe_bound) {
+ DEBUG(0, (__location__ ": Pipe already bound, "
+ "AUTH3 not supported!\n"));
+ goto err;
+ }
+
if (pkt->auth_length == 0) {
- DEBUG(1, ("No auth field sent for bind request!\n"));
+ DEBUG(1, ("No auth field sent for auth3 request!\n"));
goto err;
}