summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitay Isaacs <amitay@gmail.com>2016-08-04 15:46:33 +1000
committerStefan Metzmacher <metze@samba.org>2016-08-10 11:24:37 +0200
commitdcae84874e1eab24ad9f7a91ca6bd152c2d5cd07 (patch)
tree646f0d896233b32cf16a1aa1f0afcd8ead57016b
parenta6b4f125816ef8c2e7148d03cff77267d15926df (diff)
downloadsamba-dcae84874e1eab24ad9f7a91ca6bd152c2d5cd07.tar.gz
ctdb-tools: Fix CID 1364702 - resource leak
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12121 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 10019f7cdfa4b3f5485f063d409aa55ca5f14f6a)
-rw-r--r--ctdb/tools/ctdb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/ctdb/tools/ctdb.c b/ctdb/tools/ctdb.c
index fa38e419781..196832962b6 100644
--- a/ctdb/tools/ctdb.c
+++ b/ctdb/tools/ctdb.c
@@ -5450,11 +5450,13 @@ static int control_tfetch(TALLOC_CTX *mem_ctx, struct ctdb_context *ctdb,
nwritten = sys_write(fd, data.dptr, data.dsize);
if (nwritten != data.dsize) {
fprintf(stderr, "Failed to write record to file\n");
+ close(fd);
goto fail;
}
close(fd);
}
+
fail:
ret = ctdb_ltdb_header_extract(&data, &header);
if (ret != 0) {