summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2022-03-05 00:09:17 +0100
committerJule Anger <janger@samba.org>2022-03-16 13:41:14 +0000
commitff7ffbdf612dbf1a1e177b57deb2bcabf4152d23 (patch)
tree5dc3b38a9cda421910089cf5f862c39715edd984
parent43c4dc75e21051e41dc2ed8dc8e2c42857aa6591 (diff)
downloadsamba-ff7ffbdf612dbf1a1e177b57deb2bcabf4152d23.tar.gz
dsdb/tests: let all BasePasswordTestCase tests provide self.host_url[_ldaps]
This will make further changes easier. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13879 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 5a3214c99048a88b0a9f509e3b5b38326529b02c)
-rwxr-xr-xsource4/dsdb/tests/python/login_basics.py5
-rwxr-xr-xsource4/dsdb/tests/python/password_lockout.py7
-rw-r--r--source4/dsdb/tests/python/rodc_rwdc.py4
3 files changed, 9 insertions, 7 deletions
diff --git a/source4/dsdb/tests/python/login_basics.py b/source4/dsdb/tests/python/login_basics.py
index 91cc3c928f7..d6cac6aa058 100755
--- a/source4/dsdb/tests/python/login_basics.py
+++ b/source4/dsdb/tests/python/login_basics.py
@@ -47,7 +47,8 @@ class BasicUserAuthTests(BasePasswordTestCase):
def setUp(self):
self.host = host
- self.host_url = host_url
+ self.host_url = "ldap://%s" % host
+ self.host_url_ldaps = "ldaps://%s" % host
self.lp = lp
self.global_creds = global_creds
self.ldb = SamDB(url=self.host_url, credentials=self.global_creds,
@@ -179,6 +180,4 @@ userPassword: %s
self._test_login_basics(self.lockout1ntlm_creds)
-host_url = "ldap://%s" % host
-
TestProgram(module=__name__, opts=subunitopts)
diff --git a/source4/dsdb/tests/python/password_lockout.py b/source4/dsdb/tests/python/password_lockout.py
index 959c6489857..9aa23afd774 100755
--- a/source4/dsdb/tests/python/password_lockout.py
+++ b/source4/dsdb/tests/python/password_lockout.py
@@ -68,7 +68,8 @@ import password_lockout_base
class PasswordTests(password_lockout_base.BasePasswordTestCase):
def setUp(self):
self.host = host
- self.host_url = host_url
+ self.host_url = "ldap://%s" % host
+ self.host_url_ldaps = "ldaps://%s" % host
self.lp = lp
self.global_creds = global_creds
self.ldb = SamDB(url=self.host_url, session_info=system_session(self.lp),
@@ -139,7 +140,7 @@ lockoutTime: 0
cmd = cmd_sambatool.subcommands['user'].subcommands['unlock']
result = cmd._run("samba-tool user unlock",
username,
- "-H%s" % host_url,
+ "-H%s" % self.host_url,
"-U%s%%%s" % (global_creds.get_username(),
global_creds.get_password()))
self.assertEqual(result, None)
@@ -1421,6 +1422,4 @@ class PasswordTestsWithDefaults(PasswordTests):
self._test_login_lockout(self.lockout1ntlm_creds,
wait_lockout_duration=False)
-host_url = "ldap://%s" % host
-
TestProgram(module=__name__, opts=subunitopts)
diff --git a/source4/dsdb/tests/python/rodc_rwdc.py b/source4/dsdb/tests/python/rodc_rwdc.py
index beea26e8e1a..2ee803a8f6f 100644
--- a/source4/dsdb/tests/python/rodc_rwdc.py
+++ b/source4/dsdb/tests/python/rodc_rwdc.py
@@ -204,11 +204,13 @@ class RodcRwdcCachedTests(password_lockout_base.BasePasswordTestCase):
self.global_creds = CREDS
self.host = RWDC
self.host_url = 'ldap://%s' % RWDC
+ self.host_url_ldaps = 'ldaps://%s' % RWDC
self.ldb = SamDB(url='ldap://%s' % RWDC, session_info=system_session(self.lp),
credentials=self.global_creds, lp=self.lp)
super(RodcRwdcCachedTests, self).setUp()
self.host_url = 'ldap://%s' % RODC
+ self.host_url_ldaps = 'ldaps://%s' % RODC
self.samr = samr.samr("ncacn_ip_tcp:%s[seal]" % self.host, self.lp, self.global_creds)
self.samr_handle = self.samr.Connect2(None, security.SEC_FLAG_MAXIMUM_ALLOWED)
@@ -743,12 +745,14 @@ class RodcRwdcTests(password_lockout_base.BasePasswordTestCase):
self.global_creds = CREDS
self.host = RWDC
self.host_url = 'ldap://%s' % RWDC
+ self.host_url_ldaps = 'ldaps://%s' % RWDC
self.ldb = SamDB(url='ldap://%s' % RWDC, session_info=system_session(self.lp),
credentials=self.global_creds, lp=self.lp)
super(RodcRwdcTests, self).setUp()
self.host = RODC
self.host_url = 'ldap://%s' % RODC
+ self.host_url_ldaps = 'ldaps://%s' % RODC
self.ldb = SamDB(url='ldap://%s' % RODC, session_info=system_session(self.lp),
credentials=self.global_creds, lp=self.lp)