diff options
| author | Andreas Schneider <asn@samba.org> | 2022-03-15 12:57:18 +0100 |
|---|---|---|
| committer | Jule Anger <janger@samba.org> | 2022-03-17 09:14:56 +0000 |
| commit | 3c5d0c379d7882d8c3c45a0dde53a68c7ec8a2a7 (patch) | |
| tree | 113bc51aed19d3cf477baa998cf281636b38869d | |
| parent | 3c98408be7ddfe1d3df45b4790746eb608c2b98d (diff) | |
| download | samba-3c5d0c379d7882d8c3c45a0dde53a68c7ec8a2a7.tar.gz | |
s3:libads: Remove obsolete free's of kdc_str
This is allocated on the stackframe now!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit cca189d0934790418e27d9d01282370b1e6a057f)
| -rw-r--r-- | source3/libads/kerberos.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c index aadc65a3edc..2087dc1e6f9 100644 --- a/source3/libads/kerberos.c +++ b/source3/libads/kerberos.c @@ -443,13 +443,11 @@ static char *get_kdc_ip_string(char *mem_ctx, print_canonical_sockaddr_with_port(mem_ctx, pss)); if (kdc_str == NULL) { - TALLOC_FREE(frame); - return NULL; + goto out; } ok = sockaddr_storage_to_samba_sockaddr(&sa, pss); if (!ok) { - TALLOC_FREE(kdc_str); goto out; } @@ -467,7 +465,6 @@ static char *get_kdc_ip_string(char *mem_ctx, if (!NT_STATUS_IS_OK(status)) { DBG_ERR("get_kdc_list fail %s\n", nt_errstr(status)); - TALLOC_FREE(kdc_str); goto out; } DBG_DEBUG("got %zu addresses from site %s search\n", @@ -485,7 +482,6 @@ static char *get_kdc_ip_string(char *mem_ctx, if (!NT_STATUS_IS_OK(status)) { DBG_ERR("get_kdc_list (site-less) fail %s\n", nt_errstr(status)); - TALLOC_FREE(kdc_str); goto out; } DBG_DEBUG("got %zu addresses from site-less search\n", count_nonsite); @@ -493,7 +489,6 @@ static char *get_kdc_ip_string(char *mem_ctx, if (count_site + count_nonsite < count_site) { /* Wrap check. */ DBG_ERR("get_kdc_list_talloc (site-less) fail wrap error\n"); - TALLOC_FREE(kdc_str); goto out; } @@ -501,7 +496,6 @@ static char *get_kdc_ip_string(char *mem_ctx, dc_addrs = talloc_array(talloc_tos(), struct sockaddr_storage, count_site + count_nonsite); if (dc_addrs == NULL) { - TALLOC_FREE(kdc_str); goto out; } @@ -523,7 +517,6 @@ static char *get_kdc_ip_string(char *mem_ctx, DBG_DEBUG("%zu additional KDCs to test\n", num_dcs); if (num_dcs == 0) { - TALLOC_FREE(kdc_str); goto out; } @@ -531,7 +524,6 @@ static char *get_kdc_ip_string(char *mem_ctx, struct tsocket_address *, num_dcs); if (dc_addrs2 == NULL) { - TALLOC_FREE(kdc_str); goto out; } @@ -548,7 +540,6 @@ static char *get_kdc_ip_string(char *mem_ctx, status = map_nt_error_from_unix(errno); DEBUG(2,("Failed to create tsocket_address for %s - %s\n", addr, nt_errstr(status))); - TALLOC_FREE(kdc_str); goto out; } } @@ -566,7 +557,6 @@ static char *get_kdc_ip_string(char *mem_ctx, if (!NT_STATUS_IS_OK(status)) { DEBUG(10,("get_kdc_ip_string: cldap_multi_netlogon failed: " "%s\n", nt_errstr(status))); - TALLOC_FREE(kdc_str); goto out; } |