summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2021-07-08 11:32:20 +1000
committerJule Anger <janger@samba.org>2021-09-13 11:47:10 +0000
commitc8a9f9147c2215b14d9b666954948b592b646b12 (patch)
treec3abbaba63561b52900f75f1de25b86a0fbbb5ce
parent17e0a052da07207ad063383fb1913794c12460a6 (diff)
downloadsamba-c8a9f9147c2215b14d9b666954948b592b646b12.tar.gz
ctdb-daemon: Don't bother sending CTDB_SRVID_SET_NODE_FLAGS
The code that handles this message is ctdb_recoverd.c:monitor_handler(). Although it appears to do something potentially useful, it only logs the flags changes. All changes made are to local structures - there are no actual side-effects. It used to trigger a takeover run when the DISABLED flag changed. This was dropped back in commit 662f06de9fdce7b1bc1772a4fbe43de271564917. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14784 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit e75256767fffc6a7ac0b97e58737a39c63c8b187)
-rw-r--r--ctdb/server/ctdb_monitor.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/ctdb/server/ctdb_monitor.c b/ctdb/server/ctdb_monitor.c
index ad936925a30..67b99c61e8f 100644
--- a/ctdb/server/ctdb_monitor.c
+++ b/ctdb/server/ctdb_monitor.c
@@ -499,10 +499,5 @@ int32_t ctdb_control_modflags(struct ctdb_context *ctdb, TDB_DATA indata)
ctdb->recovery_mode = CTDB_RECOVERY_ACTIVE;
}
- /* tell the recovery daemon something has changed */
- c->new_flags = node->flags;
- ctdb_daemon_send_message(ctdb, ctdb->pnn,
- CTDB_SRVID_SET_NODE_FLAGS, indata);
-
return 0;
}