summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2020-06-25 22:42:18 +0200
committerStefan Metzmacher <metze@samba.org>2020-07-08 15:54:41 +0000
commitad3c5c1a626b73133a62f79eb58c4960912d7809 (patch)
tree4fe490adcb7a45dc2ce06ca923f23644f4f07fb8
parent4d92452890539d894315db2255f99b24e4f2a348 (diff)
downloadsamba-ad3c5c1a626b73133a62f79eb58c4960912d7809.tar.gz
s3:smbd: consistently use DLIST_ADD* to fill client->connections in smbd_add_connection()
We should not just overwrite the client->connections pointer if we reject the connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
-rw-r--r--source3/smbd/process.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/process.c b/source3/smbd/process.c
index 161672bd516..008b1986150 100644
--- a/source3/smbd/process.c
+++ b/source3/smbd/process.c
@@ -3866,7 +3866,7 @@ NTSTATUS smbd_add_connection(struct smbXsrv_client *client, int sock_fd,
* so that the caller can return an error message
* to the client
*/
- client->connections = xconn;
+ DLIST_ADD_END(client->connections, xconn);
xconn->client = client;
talloc_steal(client, xconn);