summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitay Isaacs <amitay@gmail.com>2019-09-30 16:34:35 +1000
committerStefan Metzmacher <metze@samba.org>2019-10-16 12:15:53 +0000
commit59c3bd1b15dad8de86748456a8671ff4fd1a06eb (patch)
tree86f7fd3707b3ad6847771214256129d4de75e9ec
parentfc89f8f54ba07a36ca8193f3ec7b51eede9f9728 (diff)
downloadsamba-59c3bd1b15dad8de86748456a8671ff4fd1a06eb.tar.gz
ctdb-vacuum: Process all records not deleted on a remote node
This currently skips the last record. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14147 RN: Avoid potential data loss during recovery after vacuuming error Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 33f1c9d9654fbdcb99c23f9d23c4bbe2cc596b98)
-rw-r--r--ctdb/server/ctdb_vacuum.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_vacuum.c b/ctdb/server/ctdb_vacuum.c
index 9d086917f3c..04a4cf08977 100644
--- a/ctdb/server/ctdb_vacuum.c
+++ b/ctdb/server/ctdb_vacuum.c
@@ -814,7 +814,7 @@ static void ctdb_process_delete_list(struct ctdb_db_context *ctdb_db,
*/
records = (struct ctdb_marshall_buffer *)outdata.dptr;
rec = (struct ctdb_rec_data_old *)&records->data[0];
- while (records->count-- > 1) {
+ while (records->count-- > 0) {
TDB_DATA reckey, recdata;
struct ctdb_ltdb_header *rechdr;
struct delete_record_data *dd;