diff options
| author | Volker Lendecke <vl@samba.org> | 2016-01-14 21:42:33 +0100 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2016-02-04 09:29:17 +0100 |
| commit | 89565775a4972bc5546e6b4cf858bf07f7bb42d9 (patch) | |
| tree | a03bb33cff09722a4ac49cbc606f59115cb5bf32 | |
| parent | 3d5873c848b6aa819b1a92da09e1e0f065156e2e (diff) | |
| download | samba-89565775a4972bc5546e6b4cf858bf07f7bb42d9.tar.gz | |
libwbclient: Fix a few resource leak CIDs
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
| -rw-r--r-- | nsswitch/libwbclient/tests/wbclient.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/nsswitch/libwbclient/tests/wbclient.c b/nsswitch/libwbclient/tests/wbclient.c index e011efed022..0de6096ee46 100644 --- a/nsswitch/libwbclient/tests/wbclient.c +++ b/nsswitch/libwbclient/tests/wbclient.c @@ -475,27 +475,30 @@ static bool test_wbc_lookup_rids(struct torture_context *tctx) { struct wbcDomainSid builtin; uint32_t rids[2] = { 544, 545 }; - const char *domain_name, **names; + const char *domain_name = NULL; + const char **names = NULL; enum wbcSidType *types; - wbcErr ret; + wbcErr ret = false; wbcStringToSid("S-1-5-32", &builtin); ret = wbcLookupRids(&builtin, 2, rids, &domain_name, &names, &types); - torture_assert_wbc_ok(tctx, ret, "%s", "wbcLookupRids for 544 and 545 failed"); + torture_assert_wbc_ok_goto_fail( + tctx, ret, "%s", "wbcLookupRids for 544 and 545 failed"); torture_assert_str_equal( tctx, names[0], "Administrators", "S-1-5-32-544 not mapped to 'Administrators'"); - torture_assert_str_equal( + torture_assert_str_equal_goto_fail( tctx, names[1], "Users", "S-1-5-32-545 not mapped to 'Users'"); + ret = true; +fail: wbcFreeMemory(discard_const_p(char ,domain_name)); wbcFreeMemory(names); wbcFreeMemory(types); - - return true; + return ret; } static bool test_wbc_get_sidaliases(struct torture_context *tctx) |