summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2019-09-19 11:50:01 +1200
committerKarolin Seeger <kseeger@samba.org>2019-10-24 11:45:18 +0200
commit9c8e722fea1611d31bce2d88cfef2e9588a653de (patch)
treef9de9b286aa43aca10646ffcb40ebdc2ac094a7d
parent284c98515b9963838792e8452d16294e86c899af (diff)
downloadsamba-9c8e722fea1611d31bce2d88cfef2e9588a653de.tar.gz
CVE-2019-14833: Use utf8 characters in the unacceptable password
This shows that the "check password script" handling has a bug. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438 Signed-off-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--selftest/knownfail.d/unacceptable-passwords1
-rwxr-xr-xselftest/target/Samba4.pm2
2 files changed, 2 insertions, 1 deletions
diff --git a/selftest/knownfail.d/unacceptable-passwords b/selftest/knownfail.d/unacceptable-passwords
new file mode 100644
index 00000000000..75fa2fc32b8
--- /dev/null
+++ b/selftest/knownfail.d/unacceptable-passwords
@@ -0,0 +1 @@
+^samba.tests.samba_tool.user_check_password_script.samba.tests.samba_tool.user_check_password_script.UserCheckPwdTestCase.test_checkpassword_unacceptable\(chgdcpass:local\) \ No newline at end of file
diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index b662776a847..c29e1c81ff8 100755
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -2168,7 +2168,7 @@ sub provision_chgdcpass($$)
print "PROVISIONING CHGDCPASS...\n";
# This environment disallows the use of this password
# (and also removes the default AD complexity checks)
- my $unacceptable_password = "widk3Dsle32jxdBdskldsk55klASKQ";
+ my $unacceptable_password = "Paßßword-widk3Dsle32jxdBdskldsk55klASKQ";
my $extra_smb_conf = "
check password script = sed -e '/$unacceptable_password/{;q1}; /$unacceptable_password/!{q0}'
allow dcerpc auth level connect:lsarpc = yes