diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2013-03-15 13:00:55 +1100 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2013-05-06 21:13:43 +0200 |
| commit | 973bbc449837f4c2ce07bc0403267fed83f340a9 (patch) | |
| tree | a2bd992b476966a00bd5551437aff4e66c7cb0fc | |
| parent | ae3aa281ab43f67d4f8337bafdefc08bd44712ea (diff) | |
| download | samba-973bbc449837f4c2ce07bc0403267fed83f340a9.tar.gz | |
auth/ntlmssp: Avoid use-after-free of user_info after logon failure at log level 5
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1dcd75df4941d7032a66d3fbb86ac76964444a3f)
Fix bug #9834 - segfault when loging in with wrong password from w2k8r2.
| -rw-r--r-- | auth/ntlmssp/ntlmssp_server.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/auth/ntlmssp/ntlmssp_server.c b/auth/ntlmssp/ntlmssp_server.c index d9bea1cde4b..442bd5db494 100644 --- a/auth/ntlmssp/ntlmssp_server.c +++ b/auth/ntlmssp/ntlmssp_server.c @@ -449,11 +449,11 @@ static NTSTATUS ntlmssp_server_check_password(struct gensec_security *gensec_sec &gensec_ntlmssp->server_returned_info, user_session_key, lm_session_key); } - talloc_free(user_info); if (!NT_STATUS_IS_OK(nt_status)) { DEBUG(5, (__location__ ": Checking NTLMSSP password for %s\\%s failed: %s\n", user_info->client.domain_name, user_info->client.account_name, nt_errstr(nt_status))); } + TALLOC_FREE(user_info); NT_STATUS_NOT_OK_RETURN(nt_status); |