summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2008-05-14 19:05:26 -0700
committerJeremy Allison <jra@samba.org>2008-05-14 19:05:26 -0700
commit9727d87e7c8748fecf7df5664320507711a7d081 (patch)
tree851f0867a98ac26d4b367b4043327ab4f68f2934
parent614063e0b892adb31c4b5c016669bc8e68da7632 (diff)
downloadsamba-9727d87e7c8748fecf7df5664320507711a7d081.tar.gz
lm_session_key is only 8 bytes. Don't confuse developers (ie. me :-)
by passing around 16 bytes, 8 of which end up unused. Jeremy.
-rw-r--r--source/rpc_parse/parse_net.c2
-rw-r--r--source/rpc_server/srv_netlog_nt.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/source/rpc_parse/parse_net.c b/source/rpc_parse/parse_net.c
index 5837ee6fd84..693de2d584d 100644
--- a/source/rpc_parse/parse_net.c
+++ b/source/rpc_parse/parse_net.c
@@ -1430,7 +1430,7 @@ void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr,
uint32 num_groups, const DOM_GID *gids,
uint32 user_flgs, uint32 acct_flags,
uchar user_session_key[16],
- uchar lm_session_key[16],
+ uchar lm_session_key[8],
const char *logon_srv, const char *logon_dom,
const DOM_SID *dom_sid)
{
diff --git a/source/rpc_server/srv_netlog_nt.c b/source/rpc_server/srv_netlog_nt.c
index b8c776964e9..605fae71279 100644
--- a/source/rpc_server/srv_netlog_nt.c
+++ b/source/rpc_server/srv_netlog_nt.c
@@ -973,7 +973,7 @@ static NTSTATUS _net_sam_logon_internal(pipes_struct *p,
fstring user_sid_string;
fstring group_sid_string;
unsigned char user_session_key[16];
- unsigned char lm_session_key[16];
+ unsigned char lm_session_key[8];
unsigned char pipe_session_key[16];
sampw = server_info->sam_account;
@@ -1054,7 +1054,7 @@ static NTSTATUS _net_sam_logon_internal(pipes_struct *p,
}
memcpy(pipe_session_key, p->auth.a_u.schannel_auth->sess_key, 16);
}
- SamOEMhash(lm_session_key, pipe_session_key, 16);
+ SamOEMhash(lm_session_key, pipe_session_key, 8);
memset(pipe_session_key, '\0', 16);
}