summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGerald Carter <jerry@samba.org>2006-07-03 16:13:10 +0000
committerGerald Carter <jerry@samba.org>2006-07-03 16:13:10 +0000
commit8714a9a83605ce716a3a568fa24dcba74553c248 (patch)
treec8d4935e68d5ab9a06dfb5697cdbaa9a00634c4e
parent81767e2d1a7d8661b0f2eee5827c660fd366183a (diff)
downloadsamba-8714a9a83605ce716a3a568fa24dcba74553c248.tar.gz
r16786: * merge fix for BUG 3908 (pw change failure)
* create pch file in builddir * update release notes
-rw-r--r--WHATSNEW.txt2
-rw-r--r--source/Makefile.in4
-rw-r--r--source/rpc_server/srv_pipe.c3
3 files changed, 7 insertions, 2 deletions
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index bfd86802f22..5f8a8c402c7 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -178,6 +178,8 @@ o Gerald (Jerry) Carter <jerry@samba.org>
* Fix broken compile of unsupported smbwrapper utility.
* BUG 3905: Fix smbd startup failure caused by a failure to
create an NT token for the guest account.
+ * BUG 3908: Fix RPC bind authentication failure which broke
+ user password changes.
o Guenther Deschner <gd@samba.org>
diff --git a/source/Makefile.in b/source/Makefile.in
index c8174d84405..127936125bf 100644
--- a/source/Makefile.in
+++ b/source/Makefile.in
@@ -851,8 +851,8 @@ MAKEDIR = || exec false; \
# this adds support for precompiled headers. To use it, install a snapshot
# of gcc-3.4 and run 'make pch' before you do the main build.
pch: proto_exists
- rm -f $(srcdir)/include/includes.h.gch
- $(CC) -I. -I$(srcdir) $(FLAGS) @PIE_CFLAGS@ -c $(srcdir)/include/includes.h -o $(srcdir)/include/includes.h.gch
+ rm -f $(builddir)/include/includes.h.gch
+ $(CC) -I. -I$(srcdir) $(FLAGS) @PIE_CFLAGS@ -c $(srcdir)/include/includes.h -o $(builddir)/include/includes.h.gch
# These dependencies are only approximately correct: we want to make
# sure Samba's paths are updated if ./configure is re-run. Really it
diff --git a/source/rpc_server/srv_pipe.c b/source/rpc_server/srv_pipe.c
index 72298520e3e..b4787f652df 100644
--- a/source/rpc_server/srv_pipe.c
+++ b/source/rpc_server/srv_pipe.c
@@ -620,7 +620,10 @@ static BOOL pipe_ntlmssp_verify_final(pipes_struct *p, DATA_BLOB *p_resp_blob)
p->pipe_user.ut.ngroups = 0;
SAFE_FREE( p->pipe_user.ut.groups);
+ /* this has to be done as root in order to verify the password */
+ become_root();
status = auth_ntlmssp_update(a, *p_resp_blob, &reply);
+ unbecome_root();
/* Don't generate a reply. */
data_blob_free(&reply);