Looking at string_sub() - which seems to be the cause of Olaf's complaints,

it looks like the lengths which were converted to size_t's should have
been ssize_t's in these two functions. At one point two lengths are
subtracted, and this should be a signed type.
Jeremy.

1 files changed, 8 insertions, 8 deletions

diff --git a/source/lib/util_str.c b/source/lib/util_str.c
index 32232a09e58..16d951c0be8 100644
--- a/source/lib/util_str.c
+++ b/source/lib/util_str.c
@@ -1020,13 +1020,13 @@ any of " ; ' or ` in the insert string are replaced with _
 void string_sub(char *s,const char *pattern,const char *insert)
 {
 	char *p;
-	size_t ls,lp,li, i;
+	ssize_t ls,lp,li, i;
 
 	if (!insert || !pattern || !s) return;
 
-	ls = strlen(s);
-	lp = strlen(pattern);
-	li = strlen(insert);
+	ls = (ssize_t)strlen(s);
+	lp = (ssize_t)strlen(pattern);
+	li = (ssize_t)strlen(insert);
 
 	if (!*pattern) return;
 	
@@ -1057,13 +1057,13 @@ Use with caution!
 void all_string_sub(char *s,const char *pattern,const char *insert)
 {
 	char *p;
-	size_t ls,lp,li;
+	ssize_t ls,lp,li;
 
 	if (!insert || !pattern || !s) return;
 
-	ls = strlen(s);
-	lp = strlen(pattern);
-	li = strlen(insert);
+	ls = (ssize_t)strlen(s);
+	lp = (ssize_t)strlen(pattern);
+	li = (ssize_t)strlen(insert);
 
 	if (!*pattern) return;