summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2008-09-09 16:18:27 +1000
committerAndrew Bartlett <abartlet@samba.org>2008-09-09 16:21:22 +1000
commit937b466266256d26d02cf8d48e72a26272fe8627 (patch)
treead250b1e7a38db64f011142fb553fdb499c8db7b
parent6f89e728272ca14f0ed9557485e21647c0731ef2 (diff)
downloadsamba-937b466266256d26d02cf8d48e72a26272fe8627.tar.gz
Fix bug #5713 by correcting the generated schema.
This bug is entitled 'Schema patch breaks interoperability with Microsoft MMC consoles.', and it does so very spectacularly. The issue is that we would include an entry: objectClasses: ( 2.5.6.0 NAME 'top' SUP top ABSTRACT.. The MMC Active Directory Users and Computers snap in presumably objected to the 'loop' this would present. The fixed entry is: objectClasses: ( 2.5.6.0 NAME 'top' ABSTRACT Thanks to Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> for his persistance in getting me to look at this. Andrew Bartlett
-rw-r--r--source/dsdb/schema/schema_description.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source/dsdb/schema/schema_description.c b/source/dsdb/schema/schema_description.c
index 9d93af9260a..d780fcf34f8 100644
--- a/source/dsdb/schema/schema_description.c
+++ b/source/dsdb/schema/schema_description.c
@@ -182,7 +182,7 @@ char *schema_class_description(TALLOC_CTX *mem_ctx,
IF_NULL_FAIL_RET(schema_entry);
}
- if (subClassOf) {
+ if (subClassOf && strcasecmp(subClassOf, name) == 0) {
schema_entry = talloc_asprintf_append(schema_entry,
"SUP %s%s", subClassOf, seperator);
IF_NULL_FAIL_RET(schema_entry);