diff options
| author | Simo Sorce <idra@samba.org> | 2008-09-03 10:44:09 -0400 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2008-09-14 19:19:55 +0200 |
| commit | 8fd54bb55f0c23bd025d1719abcbe75c6a2ea8ac (patch) | |
| tree | ce8add9a0cd74eadb2e55576ed9dfa3662ce1537 | |
| parent | 1d85e0647e287d269b3f6b534da88f497d6f76c3 (diff) | |
| download | samba-8fd54bb55f0c23bd025d1719abcbe75c6a2ea8ac.tar.gz | |
The msync manpage reports that msync *must* be called before munmap. Failure to do so may result in lost data. Fix an ifdef check, I really think we meant to check HAVE_MMAP here.
(cherry picked from commit 74c8575b3f3b90ea21ae6aa7ccd95947838af956)
| -rw-r--r-- | source/lib/tdb/common/io.c | 8 | ||||
| -rw-r--r-- | source/lib/tdb/common/transaction.c | 2 |
2 files changed, 8 insertions, 2 deletions
diff --git a/source/lib/tdb/common/io.c b/source/lib/tdb/common/io.c index 172ab69d8c9..4ec18de48e0 100644 --- a/source/lib/tdb/common/io.c +++ b/source/lib/tdb/common/io.c @@ -189,7 +189,13 @@ int tdb_munmap(struct tdb_context *tdb) #ifdef HAVE_MMAP if (tdb->map_ptr) { - int ret = munmap(tdb->map_ptr, tdb->map_size); + int ret; + + ret = msync(tdb->map_ptr, tdb->map_size, MS_SYNC); + if (ret != 0) + return ret; + + ret = munmap(tdb->map_ptr, tdb->map_size); if (ret != 0) return ret; } diff --git a/source/lib/tdb/common/transaction.c b/source/lib/tdb/common/transaction.c index 4e2127be644..7acda640c8d 100644 --- a/source/lib/tdb/common/transaction.c +++ b/source/lib/tdb/common/transaction.c @@ -563,7 +563,7 @@ static int transaction_sync(struct tdb_context *tdb, tdb_off_t offset, tdb_len_t TDB_LOG((tdb, TDB_DEBUG_FATAL, "tdb_transaction: fsync failed\n")); return -1; } -#ifdef MS_SYNC +#ifdef HAVE_MMAP if (tdb->map_ptr) { tdb_off_t moffset = offset & ~(tdb->page_size-1); if (msync(moffset + (char *)tdb->map_ptr, |