diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2021-03-06 09:57:44 +1300 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2021-11-02 20:36:16 +0000 |
| commit | 461096c521ce3e0c884161bf75902a8963878e61 (patch) | |
| tree | 5bbf51f89a1a1acaab4afcad1d7956ddf30ea7be | |
| parent | e4741f2a11989f34fd9ab85c574c99774a5f7994 (diff) | |
| download | samba-461096c521ce3e0c884161bf75902a8963878e61.tar.gz | |
ldb: correct comments in attrib_handers val_to_int64
c.f. the identical static function in lib/ldb-samba/ldif_handlers.c
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 46e6f6ef8436df7e083f34556c25f66f65ea1ce5)
| -rw-r--r-- | lib/ldb/common/attrib_handlers.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/ldb/common/attrib_handlers.c b/lib/ldb/common/attrib_handlers.c index 6a885065f77..febf2f414ca 100644 --- a/lib/ldb/common/attrib_handlers.c +++ b/lib/ldb/common/attrib_handlers.c @@ -97,7 +97,7 @@ int ldb_handler_fold(struct ldb_context *ldb, void *mem_ctx, return 0; } -/* length limited conversion of a ldb_val to a int32_t */ +/* length limited conversion of a ldb_val to an int64_t */ static int val_to_int64(const struct ldb_val *in, int64_t *v) { char *end; @@ -110,8 +110,6 @@ static int val_to_int64(const struct ldb_val *in, int64_t *v) strncpy(buf, (char *)in->data, in->length); buf[in->length] = 0; - /* We've to use "strtoll" here to have the intended overflows. - * Otherwise we may get "LONG_MAX" and the conversion is wrong. */ *v = (int64_t) strtoll(buf, &end, 0); if (*end != 0) { return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX; |