summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Disseldorp <ddiss@samba.org>2014-12-17 16:47:50 +0100
committerAndreas Schneider <asn@cryptomilk.org>2014-12-19 15:40:43 +0100
commitc9fccb5018f9a19bb654b9ad79aa716e37a274d6 (patch)
tree788122ef42a0211bd9cca4112fcf7080ce6b37bb
parent679c781112ce6b7cffca11c28e58ae5f9a0d717d (diff)
downloadsamba-c9fccb5018f9a19bb654b9ad79aa716e37a274d6.tar.gz
spoolss: clear info on GetPrinterDriverDirectory error
If an error is returned without zeroing a pre-allocated @info pointer, then marshalling of the response will fail. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
-rw-r--r--source3/rpc_server/spoolss/srv_spoolss_nt.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index c8c670b1123..c34b04de898 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -8544,6 +8544,7 @@ WERROR _spoolss_GetPrinterDriverDirectory(struct pipes_struct *p,
/* that's an [in out] buffer */
if (!r->in.buffer && (r->in.offered != 0)) {
+ TALLOC_FREE(r->out.info);
return WERR_INVALID_PARAM;
}