diff options
| author | Stefan Metzmacher <metze@samba.org> | 2014-12-17 10:43:33 +0100 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2014-12-18 04:22:05 +0100 |
| commit | 6bc41c459f6da7de62d2113590bc7d0c2d04e136 (patch) | |
| tree | 5cb227ebc87818625d7649a90315f8986e8691ca | |
| parent | 53fb00e5d59c0e69a44ba54eeedc3a48a5322e9f (diff) | |
| download | samba-6bc41c459f6da7de62d2113590bc7d0c2d04e136.tar.gz | |
s3:locking: fix uninitialiazed variable in brl_get_locks_readonly_parser()
In a cluster this can be called with an empty record, while
brl_parse_data() relies on an initialized structure.
This is a regression in commit 837e29035c911f3509135252c3f423d0f56b606d.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10911
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
| -rw-r--r-- | source3/locking/brlock.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/locking/brlock.c b/source3/locking/brlock.c index 6c73c725dd1..7fd3783cb86 100644 --- a/source3/locking/brlock.c +++ b/source3/locking/brlock.c @@ -2014,6 +2014,7 @@ static void brl_get_locks_readonly_parser(TDB_DATA key, TDB_DATA data, *state->br_lock = NULL; return; } + *br_lck = (struct byte_range_lock) {}; if (!brl_parse_data(br_lck, data)) { *state->br_lock = NULL; return; |