summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix another redundant regexrubocop_RedundantParenthesesTim Smith2020-09-081-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Resolve RuboCop Style/RedundantParentheses warningsTim Smith2020-09-0812-15/+15
| | | | | | Simplify the code so it's easier to read Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.15 by Chef Expeditorv16.4.15Chef Expeditor2020-09-083-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1506 from chef/dependabot/bundler/rubocop-performance-1.8.0Tim Smith2020-09-084-14/+6
|\ | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Remove unused spec helpersTim Smith2020-09-082-13/+1
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Updates for the new perf copsTim Smith2020-09-083-4/+8
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Update rubocop-performance requirement from 1.7.1 to 1.8.0dependabot-preview[bot]2020-09-081-1/+1
| | | | | | | | | | | | | | | | Updates the requirements on [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases) - [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.7.1...v1.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* | Bump version to 16.4.14 by Chef Expeditorv16.4.14Chef Expeditor2020-09-083-5/+6
|/ | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1507 from chef/chefstyleTim Smith2020-09-083-14/+12
|\ | | | | Resolve new chefstyle warnings & use safe navigators
| * Bail out early to avoid safe operatorchefstyleTim Smith2020-09-081-3/+5
| | | | | | | | | | | | | | | | | | Also add some notes here that we should convert this to a filter_map when we can as that's easier to read and faster. Perf benchmarks from the tubes: Signed-off-by: Tim Smith <tsmith@chef.io>
| * Simplify respond_to?Tim Smith2020-09-081-1/+1
| | | | | | | | | | | | There's no need for the &. here Signed-off-by: Tim Smith <tsmith@chef.io>
| * Simplify things with &.Tim Smith2020-09-083-13/+9
| | | | | | | | | | | | We can avoid some duplicate checks by using &. in places Signed-off-by: Tim Smith <tsmith@chef.io>
| * Resolve new chefstyle warningsTim Smith2020-08-252-2/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #1504 from chef/lcg/remove-copyright-datesLamont Granquist2020-08-27165-165/+165
|\ \ | | | | | | Remove Copyright Dates
| * | Remove Copyright DatesLamont Granquist2020-08-27165-165/+165
|/ / | | | | | | | | | | end the insanity Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version to 16.4.13 by Chef Expeditorv16.4.13Chef Expeditor2020-08-263-4/+12
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #1501 from chef/lcg/chef-utils-helpersTim Smith2020-08-2512-122/+195
|\ \ | |/ |/| Migrate to the chef-utils helpers for which/shell_out
| * Try to fix windows unitslcg/chef-utils-helpersLamont Granquist2020-08-251-5/+6
| | | | | | | | | | | | | | | | This throws warnings, but I'm a bit out of ideas today. This lies like crazy to make it work on windows. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix case sensitive windows pathLamont Granquist2020-08-251-1/+3
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * trying to fix windows testsLamont Granquist2020-08-251-16/+19
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * chefstyleLamont Granquist2020-08-253-3/+3
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix the deafult localeLamont Granquist2020-08-251-3/+4
| | | | | | | | | | | | we need to call out to the ChefConfig helper to set this Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix specsLamont Granquist2020-08-251-1/+3
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * code reviewLamont Granquist2020-08-244-4/+4
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * single quotes againLamont Granquist2020-08-211-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Fix the PATH for the way it gets de-duplicatedLamont Granquist2020-08-211-1/+1
| | | | | | | | | | | | The default paths algorithm is a little bit weird Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * remove hardcoded path from my machineLamont Granquist2020-08-211-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Migrate to the chef-utils helpersLamont Granquist2020-08-219-112/+176
|/ | | | | | This replaces the which/shell_out helpers with ones from chef-utils. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Update CHANGELOG.md to reflect the promotion of 16.4.12Chef Expeditor2020-08-191-12/+9
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Update CHANGELOG.mdTim Smith2020-08-191-4/+2
| | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md to reflect the promotion of 16.4.11Chef Expeditor2020-08-191-1/+3
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.12 by Chef Expeditorv16.4.12Chef Expeditor2020-08-193-4/+12
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1500 from chef/networkTim Smith2020-08-191-1/+1
|\ | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add missing require for windows network pluginnetworkTim Smith2020-08-191-1/+1
|/ | | | | | | | This was missed since the windows network plugin just mocks out the IP data. I'll see what I can do to make these more real world tests in a followup PR Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md to reflect the promotion of 16.4.11Chef Expeditor2020-08-141-22/+19
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.11 by Chef Expeditorv16.4.11Chef Expeditor2020-08-123-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1497 from chef/requiresTim Smith2020-08-122-2/+2
|\ | | | | Optimize 2 of our requires
| * Optimize 2 of our requiresrequiresTim Smith2020-08-122-2/+2
|/ | | | | | Only include set if we need to and use require_relative which is faster Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.10 by Chef Expeditorv16.4.10Chef Expeditor2020-08-123-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1495 from chef/rubocop_performanceTim Smith2020-08-122-0/+6
|\ | | | | Use rubocop-performance to enforce some best practices
| * Use rubocop-performance to enforce some best practicesrubocop_performanceTim Smith2020-08-112-0/+6
| | | | | | | | | | | | I've already fixed all the warnings. This will keep it that way. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.4.9 by Chef Expeditorv16.4.9Chef Expeditor2020-08-123-5/+6
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #1496 from chef/remove_profileTim Smith2020-08-121-5/+1
|\ \ | |/ |/| Remove profile gemfile group for now
| * Remove profile gemfile group for nowremove_profileTim Smith2020-08-121-5/+1
|/ | | | | | This causes bundle install issues on windows Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.8 by Chef Expeditorv16.4.8Chef Expeditor2020-08-103-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.7 by Chef Expeditorv16.4.7Chef Expeditor2020-08-103-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1493 from chef/fix_requireTim Smith2020-08-102-3/+2
|\ | | | | Update network plugin to use ipaddr not ipaddress gem
| * Update network plugin to use ipaddr not ipaddress gemfix_requireTim Smith2020-08-102-3/+2
| | | | | | | | | | | | This broke because we never actually required ipaddress in the plugin, but the specs passed because we required it there. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #1494 from chef/remove_requiresTim Smith2020-08-107-9/+0
|\ \ | | | | | | Remove non-Ohai requires from specs to prevent false positives
| * | Remove non-Ohai requires from specs to prevent false positivesremove_requiresTim Smith2020-08-107-9/+0
|/ / | | | | | | | | | | The plugins should require everything they need unless we're using those library to mock out objects like we do in some Windows specs. This way we rely on the requires in the plugins and specs fail if those requires are removed. Signed-off-by: Tim Smith <tsmith@chef.io>