Remove the deprecated run_command and popen4 methodscommand

This is very much legacy and has long since been replaced by shell_out

Signed-off-by: Tim Smith <tsmith@chef.io>

1 files changed, 0 insertions, 68 deletions

diff --git a/spec/unit/mixin/command_spec.rb b/spec/unit/mixin/command_spec.rb
index fb4ce87f..e9afa2cd 100644
--- a/spec/unit/mixin/command_spec.rb
+++ b/spec/unit/mixin/command_spec.rb
@@ -19,74 +19,6 @@
 
 require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
 
-describe Ohai::Mixin::Command, "popen4" do
-  break if RUBY_PLATFORM =~ /(win|w)32$/
-
-  it "should default all commands to be run in the POSIX standard C locale" do
-    Ohai::Mixin::Command.popen4("echo $LC_ALL") do |pid, stdin, stdout, stderr|
-      stdin.close
-      expect(stdout.read.strip).to eq("C")
-    end
-  end
-
-  it "should respect locale when specified explicitly" do
-    Ohai::Mixin::Command.popen4("echo $LC_ALL", :environment => { "LC_ALL" => "es" }) do |pid, stdin, stdout, stderr|
-      stdin.close
-      expect(stdout.read.strip).to eq("es")
-    end
-  end
-
-  if defined?(::Encoding) && "".respond_to?(:force_encoding) #i.e., ruby 1.9
-    context "when external commands return UTF-8 strings and we are running under LANG=C encoding" do
-      before do
-        @saved_default_external = Encoding.default_external
-        @saved_default_internal = Encoding.default_internal
-        Encoding.default_external = Encoding::US_ASCII
-        Encoding.default_internal = Encoding::US_ASCII
-      end
-
-      after do
-        Encoding.default_external = @saved_default_external
-        Encoding.default_internal = @saved_default_internal
-      end
-
-      it "should force encode the string to UTF-8" do
-        extend Ohai::Mixin::Command
-        snowy = run_command(:command => ("echo '" + ("☃" * 8096) + "'"))[1]
-        expect(snowy.encoding).to eq(Encoding::UTF_8)
-      end
-    end
-
-    it "should force encode the string to UTF-8" do
-      extend Ohai::Mixin::Command
-      snowy = run_command(:command => ("echo '" + ("☃" * 8096) + "'"))[1]
-      expect(snowy.encoding).to eq(Encoding::UTF_8)
-    end
-  end
-
-  it "reaps zombie processes after exec fails [OHAI-455]" do
-    # NOTE: depending on ulimit settings, GC, etc., before the OHAI-455 patch,
-    # ohai could also exhaust the available file descriptors when creating this
-    # many zombie processes. A regression _could_ cause Errno::EMFILE but this
-    # probably won't be consistent on different environments.
-    created_procs = 0
-    100.times do
-      begin
-        Ohai::Mixin::Command.popen4("/bin/this-is-not-a-real-command") { |p, i, o, e| nil }
-      rescue Ohai::Exceptions::Exec
-        created_procs += 1
-      end
-    end
-    expect(created_procs).to eq(100)
-    reaped_procs = 0
-    begin
-      loop { Process.wait(-1); reaped_procs += 1 }
-    rescue Errno::ECHILD
-    end
-    expect(reaped_procs).to eq(0)
-  end
-end
-
 describe Ohai::Mixin::Command, "shell_out" do
   let(:cmd) { "sparkle-dream --version" }