diff options
author | Tim Smith <tsmith@chef.io> | 2016-04-18 18:49:33 -0700 |
---|---|---|
committer | Tim Smith <tsmith@chef.io> | 2016-04-18 18:49:33 -0700 |
commit | 508366cf050d77ea17329054089785d684565951 (patch) | |
tree | f6e6ec9a95f37cc6798963dbba3e5c04d0379610 /spec/unit | |
parent | c9e16f4199577de462be838c141e6a354d8f23cb (diff) | |
parent | c19fb5f371ebb203af7665c7e24e8cfb8d5151a5 (diff) | |
download | ohai-508366cf050d77ea17329054089785d684565951.tar.gz |
Merge pull request #801 from chef/erlang
Correct the version detection in erlang plugin
Diffstat (limited to 'spec/unit')
-rw-r--r-- | spec/unit/plugins/erlang_spec.rb | 52 |
1 files changed, 29 insertions, 23 deletions
diff --git a/spec/unit/plugins/erlang_spec.rb b/spec/unit/plugins/erlang_spec.rb index cdb0a340..0f407b69 100644 --- a/spec/unit/plugins/erlang_spec.rb +++ b/spec/unit/plugins/erlang_spec.rb @@ -20,41 +20,47 @@ require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb") describe Ohai::System, "plugin erlang" do + let(:plugin) { get_plugin("erlang") } before(:each) do - @plugin = get_plugin("erlang") - @plugin[:languages] = Mash.new - @stderr = "Erlang (ASYNC_THREADS,SMP,HIPE) (BEAM) emulator version 5.6.2\n" - allow(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr)) + plugin[:languages] = Mash.new + erl_v_output = "Erlang (SMP,ASYNC_THREADS,HIPE) (BEAM) emulator version 7.3\n" + erl_systeminfo_output = "\"18\"\r\n\"7.3\"\r\n\"2.10\"\r\n" + allow(plugin).to receive(:shell_out).with("erl +V") + .and_return(mock_shell_out(0, "", erl_v_output)) + allow(plugin).to receive(:shell_out).with("erl -eval 'erlang:display(erlang:system_info(otp_release)), erlang:display(erlang:system_info(version)), erlang:display(erlang:system_info(nif_version)), halt().' -noshell") + .and_return(mock_shell_out(0, erl_systeminfo_output, "")) end - it "should get the erlang version from erl +V" do - expect(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr)) - @plugin.run + it "sets languages[:erlang][:options]" do + plugin.run + expect(plugin.languages[:erlang][:options]).to eql(%w{SMP ASYNC_THREADS HIPE}) end - it "should set languages[:erlang][:version]" do - @plugin.run - expect(@plugin.languages[:erlang][:version]).to eql("5.6.2") + it "sets languages[:erlang][:emulator]" do + plugin.run + expect(plugin.languages[:erlang][:emulator]).to eql("BEAM") end - it "should set languages[:erlang][:options]" do - @plugin.run - expect(@plugin.languages[:erlang][:options]).to eql(%w{ASYNC_THREADS SMP HIPE}) + it "sets languages[:erlang][:version]" do + plugin.run + expect(plugin.languages[:erlang][:version]).to eql("18") end - it "should set languages[:erlang][:emulator]" do - @plugin.run - expect(@plugin.languages[:erlang][:emulator]).to eql("BEAM") + it "sets languages[:erlang][:erts_version]" do + plugin.run + expect(plugin.languages[:erlang][:erts_version]).to eql("7.3") end - it "should not set the languages[:erlang] tree up if erlang command fails" do - @status = 1 - @stdin = "" - @stderr = "Erlang (ASYNC_THREADS,SMP,HIPE) (BEAM) emulator version 5.6.2\n" - allow(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(1, "", @stderr)) - @plugin.run - expect(@plugin.languages).not_to have_key(:erlang) + it "sets languages[:erlang][:nif_version]" do + plugin.run + expect(plugin.languages[:erlang][:nif_version]).to eql("2.10") + end + + it "does not set languages[:erlang] if the erl commands fails" do + allow(plugin).to receive(:shell_out).and_raise(Ohai::Exceptions::Exec) + plugin.run + expect(plugin.languages).not_to have_key(:erlang) end end |