diff options
-rw-r--r-- | .rubocop.yml | 1 | ||||
-rw-r--r-- | .rubocop_todo.yml | 1145 | ||||
-rw-r--r-- | test/common.rb | 2 |
3 files changed, 1147 insertions, 1 deletions
diff --git a/.rubocop.yml b/.rubocop.yml new file mode 100644 index 0000000..cc32da4 --- /dev/null +++ b/.rubocop.yml @@ -0,0 +1 @@ +inherit_from: .rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 0000000..2913e69 --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,1145 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2016-03-30 13:23:48 +0200 using RuboCop version 0.39.0. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 9 +# Configuration parameters: AllowSafeAssignment. +Lint/AssignmentInCondition: + Exclude: + - 'lib/net/ssh/connection/channel.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/proxy/command.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: AlignWith, SupportedStyles. +# SupportedStyles: either, start_of_block, start_of_line +Lint/BlockAlignment: + Exclude: + - 'test/integration/test_proxy.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +Lint/Debugger: + Exclude: + - 'quicktest.rb' + - 'test.rb' + - 'test_connection_close_shall_close_cannels.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Lint/DeprecatedClassMethods: + Exclude: + - 'Rakefile' + +# Offense count: 217 +# Cop supports --auto-correct. +# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect. +# SupportedStyles: keyword, variable, start_of_line +Lint/EndAlignment: + Enabled: false + +# Offense count: 12 +Lint/HandleExceptions: + Exclude: + - 'lib/net/ssh/authentication/session.rb' + - 'lib/net/ssh/known_hosts.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'test/integration/common.rb' + - 'test/integration/test_forward.rb' + - 'test/manual/test_pageant.rb' + - 'test/start/test_connection.rb' + - 'test/start/test_transport.rb' + +# Offense count: 72 +Lint/ImplicitStringConcatenation: + Exclude: + - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + +# Offense count: 3 +Lint/LiteralInCondition: + Exclude: + - 'lib/net/ssh/authentication/pageant.rb' + - 'quicktest.rb' + +# Offense count: 2 +Lint/Loop: + Exclude: + - 'lib/net/ssh/authentication/methods/password.rb' + - 'lib/net/ssh/key_factory.rb' + +# Offense count: 12 +Lint/NestedMethodDefinition: + Exclude: + - 'lib/net/ssh/transport/ctr.rb' + - 'test/authentication/methods/test_keyboard_interactive.rb' + +# Offense count: 1 +Lint/NextWithoutAccumulator: + Exclude: + - 'lib/net/ssh/connection/session.rb' + +# Offense count: 1 +Lint/NonLocalExitFromIterator: + Exclude: + - 'lib/net/ssh/known_hosts.rb' + +# Offense count: 4 +Lint/RescueException: + Exclude: + - 'lib/net/ssh/authentication/key_manager.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + +# Offense count: 9 +Lint/ShadowingOuterLocalVariable: + Exclude: + - 'quicktest_1_open_channel_nb.rb' + - 'quicktest_337.rb' + - 'quicktest_4gb.rb' + +# Offense count: 1 +Lint/UnderscorePrefixedVariableName: + Exclude: + - 'lib/net/ssh/test/local_packet.rb' + +# Offense count: 53 +# Cop supports --auto-correct. +# Configuration parameters: IgnoreEmptyBlocks. +Lint/UnusedBlockArgument: + Exclude: + - 'lib/net/ssh/connection/keepalive.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/service/forward.rb' + - 'quicktest_337.rb' + - 'quicktest_4gb.rb' + - 'test/authentication/methods/test_password.rb' + - 'test/authentication/test_agent.rb' + - 'test/common.rb' + - 'test/connection/test_channel.rb' + - 'test/connection/test_session.rb' + - 'test/transport/test_algorithms.rb' + - 'test/transport/test_hmac.rb' + +# Offense count: 44 +# Cop supports --auto-correct. +# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. +Lint/UnusedMethodArgument: + Enabled: false + +# Offense count: 3 +Lint/UselessAccessModifier: + Exclude: + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/connection/channel.rb' + - 'lib/net/ssh/transport/session.rb' + +# Offense count: 12 +Lint/UselessAssignment: + Exclude: + - 'lib/net/ssh/key_factory.rb' + - 'lib/net/ssh/proxy/socks4.rb' + - 'lib/net/ssh/proxy/socks5.rb' + - 'quicktest_337.rb' + - 'test/integration/common.rb' + - 'test/integration/test_forward.rb' + +# Offense count: 185 +Metrics/AbcSize: + Max: 91 + +# Offense count: 2 +Metrics/BlockNesting: + Max: 4 + +# Offense count: 31 +# Configuration parameters: CountComments. +Metrics/ClassLength: + Max: 1130 + +# Offense count: 34 +Metrics/CyclomaticComplexity: + Max: 39 + +# Offense count: 1275 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes. +# URISchemes: http, https +Metrics/LineLength: + Max: 934 + +# Offense count: 166 +# Configuration parameters: CountComments. +Metrics/MethodLength: + Max: 99 + +# Offense count: 3 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 155 + +# Offense count: 1 +# Configuration parameters: CountKeywordArgs. +Metrics/ParameterLists: + Max: 6 + +# Offense count: 28 +Metrics/PerceivedComplexity: + Max: 23 + +# Offense count: 3 +# Cop supports --auto-correct. +Performance/RangeInclude: + Exclude: + - 'lib/net/ssh/transport/algorithms.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +Performance/RedundantBlockCall: + Exclude: + - 'lib/net/ssh/connection/session.rb' + - 'test/connection/test_channel.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +Performance/RedundantMatch: + Exclude: + - 'lib/net/ssh/key_factory.rb' + - 'lib/net/ssh/transport/server_version.rb' + +# Offense count: 14 +Style/AccessorMethodName: + Exclude: + - 'lib/net/ssh/authentication/methods/password.rb' + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/prompt.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb' + - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: prefer_alias, prefer_alias_method +Style/Alias: + Exclude: + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/ctr.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/AlignArray: + Exclude: + - 'lib/net/ssh/proxy/socks5.rb' + +# Offense count: 25 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles. +# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit +Style/AlignHash: + Exclude: + - 'lib/net/ssh/transport/algorithms.rb' + - 'test/connection/test_channel.rb' + - 'test/integration/test_id_rsa_keys.rb' + - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp256.rb' + - 'test/transport/test_algorithms.rb' + - 'test/transport/test_cipher_factory.rb' + - 'test/transport/test_state.rb' + +# Offense count: 76 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: with_first_parameter, with_fixed_indentation +Style/AlignParameters: + Enabled: false + +# Offense count: 46 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: always, conditionals +Style/AndOr: + Enabled: false + +# Offense count: 3 +Style/AsciiComments: + Exclude: + - 'lib/net/ssh/authentication/agent/java_pageant.rb' + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/buffered_io.rb' + +# Offense count: 32 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods. +# SupportedStyles: line_count_based, semantic, braces_for_chaining +# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object +# FunctionalMethods: let, let!, subject, watch +# IgnoredMethods: lambda, proc, it +Style/BlockDelimiters: + Exclude: + - 'Rakefile' + - 'lib/net/ssh/authentication/key_manager.rb' + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/connection/keepalive.rb' + - 'lib/net/ssh/proxy/command.rb' + - 'lib/net/ssh/transport/ctr.rb' + - 'test/test_buffer.rb' + - 'test/verifiers/test_secure.rb' + +# Offense count: 8 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: braces, no_braces, context_dependent +Style/BracesAroundHashParameters: + Exclude: + - 'lib/net/ssh/config.rb' + - 'test/integration/test_ed25519_pkeys.rb' + - 'test/integration/test_id_rsa_keys.rb' + - 'test/transport/test_hmac.rb' + - 'test/transport/test_session.rb' + - 'test_kerberos_client2.rb' + +# Offense count: 2 +Style/CaseEquality: + Exclude: + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/connection/session.rb' + +# Offense count: 42 +# Cop supports --auto-correct. +# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth. +# SupportedStyles: case, end +Style/CaseIndentation: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +Style/CharacterLiteral: + Exclude: + - 'test/test_buffer.rb' + +# Offense count: 12 +Style/ClassAndModuleCamelCase: + Exclude: + - 'lib/net/ssh/transport/hmac/md5_96.rb' + - 'lib/net/ssh/transport/hmac/sha1_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_256.rb' + - 'lib/net/ssh/transport/hmac/sha2_256_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_512.rb' + - 'lib/net/ssh/transport/hmac/sha2_512_96.rb' + - 'test/transport/hmac/test_md5_96.rb' + - 'test/transport/hmac/test_sha1_96.rb' + - 'test/transport/hmac/test_sha2_256.rb' + - 'test/transport/hmac/test_sha2_256_96.rb' + - 'test/transport/hmac/test_sha2_512.rb' + - 'test/transport/hmac/test_sha2_512_96.rb' + +# Offense count: 15 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: nested, compact +Style/ClassAndModuleChildren: + Exclude: + - 'lib/net/ssh/transport/ctr.rb' + - 'lib/net/ssh/transport/hmac.rb' + - 'lib/net/ssh/transport/hmac/md5.rb' + - 'lib/net/ssh/transport/hmac/md5_96.rb' + - 'lib/net/ssh/transport/hmac/none.rb' + - 'lib/net/ssh/transport/hmac/ripemd160.rb' + - 'lib/net/ssh/transport/hmac/sha1.rb' + - 'lib/net/ssh/transport/hmac/sha1_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_256.rb' + - 'lib/net/ssh/transport/hmac/sha2_256_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_512.rb' + - 'lib/net/ssh/transport/hmac/sha2_512_96.rb' + - 'lib/net/ssh/transport/kex.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: is_a?, kind_of? +Style/ClassCheck: + Exclude: + - 'test/authentication/test_key_manager.rb' + +# Offense count: 7 +Style/ClassVars: + Exclude: + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/packet.rb' + - 'test/authentication/methods/test_hostbased.rb' + - 'test/authentication/methods/test_publickey.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/ColonMethodCall: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: Keywords. +# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW +Style/CommentAnnotation: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + - 'lib/net/ssh/authentication/session.rb' + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/config.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Style/CommentIndentation: + Exclude: + - 'test/integration/test_forward.rb' + - 'test/transport/test_server_version.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly. +# SupportedStyles: assign_to_condition, assign_inside_condition +Style/ConditionalAssignment: + Exclude: + - 'lib/net/ssh/transport/ctr.rb' + - 'lib/net/ssh/transport/state.rb' + - 'test/test_key_factory.rb' + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/known_hosts.rb' + - 'lib/net/ssh/proxy/socks5.rb' + - 'lib/net/ssh/test/script.rb' + +# Offense count: 8 +Style/ConstantName: + Exclude: + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/prompt.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + - 'lib/net/ssh/transport/openssl.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/DefWithParentheses: + Exclude: + - 'test/integration/test_forward.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +Style/DeprecatedHashMethods: + Exclude: + - 'lib/net/ssh/connection/session.rb' + - 'test/transport/test_packet_stream.rb' + +# Offense count: 29 +Style/Documentation: + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'lib/net/ssh/authentication/ed25519.rb' + - 'lib/net/ssh/connection/keepalive.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/ruby_compat.rb' + - 'lib/net/ssh/test/extensions.rb' + - 'lib/net/ssh/transport/hmac/sha2_256_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_512.rb' + - 'lib/net/ssh/transport/hmac/sha2_512_96.rb' + - 'lib/net/ssh/transport/kex.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb' + - 'lib/net/ssh/transport/key_expander.rb' + - 'lib/net/ssh/transport/openssl.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: leading, trailing +Style/DotPosition: + Enabled: false + +# Offense count: 3 +Style/EachWithObject: + Exclude: + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/service/forward.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/ElseAlignment: + Exclude: + - 'lib/net/ssh/packet.rb' + +# Offense count: 12 +# Cop supports --auto-correct. +# Configuration parameters: AllowAdjacentOneLineDefs. +Style/EmptyLineBetweenDefs: + Exclude: + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/ruby_compat.rb' + - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp384.rb' + - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp521.rb' + - 'test/test_buffer.rb' + - 'test/test_key_factory.rb' + +# Offense count: 22 +# Cop supports --auto-correct. +Style/EmptyLines: + Exclude: + - 'Rakefile' + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/known_hosts.rb' + - 'lib/net/ssh/transport/cipher_factory.rb' + - 'lib/net/ssh/transport/packet_stream.rb' + - 'lib/net/ssh/transport/session.rb' + - 'test/authentication/methods/test_keyboard_interactive.rb' + - 'test/authentication/methods/test_password.rb' + - 'test/integration/test_ed25519_pkeys.rb' + - 'test/integration/test_id_rsa_keys.rb' + - 'test/test_config.rb' + - 'test/test_known_hosts.rb' + - 'test/transport/test_cipher_factory.rb' + +# Offense count: 48 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: empty_lines, no_empty_lines +Style/EmptyLinesAroundClassBody: + Enabled: false + +# Offense count: 5 +# Cop supports --auto-correct. +Style/EmptyLinesAroundMethodBody: + Exclude: + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'test/authentication/methods/test_keyboard_interactive.rb' + - 'test/transport/hmac/test_sha2_256.rb' + - 'test/transport/hmac/test_sha2_512.rb' + +# Offense count: 209 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: empty_lines, no_empty_lines +Style/EmptyLinesAroundModuleBody: + Enabled: false + +# Offense count: 2 +# Cop supports --auto-correct. +Style/EmptyLiteral: + Exclude: + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/EvenOdd: + Exclude: + - 'lib/net/ssh/buffer.rb' + +# Offense count: 28 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. +Style/ExtraSpacing: + Exclude: + - 'Rakefile' + - 'lib/net/ssh/authentication/methods/password.rb' + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/proxy/socks5.rb' + - 'lib/net/ssh/transport/hmac/sha2_256_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_512_96.rb' + - 'quicktest_337.rb' + - 'test/authentication/test_key_manager.rb' + - 'test/integration/test_forward.rb' + - 'test/test_config.rb' + - 'test/test_key_factory.rb' + - 'test/transport/test_packet_stream.rb' + +# Offense count: 3 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: format, sprintf, percent +Style/FormatString: + Exclude: + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/loggable.rb' + + +# Offense count: 11 +# Configuration parameters: MinBodyLength. +Style/GuardClause: + Exclude: + - 'lib/net/ssh.rb' + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/connection/channel.rb' + - 'lib/net/ssh/key_factory.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'lib/net/ssh/transport/algorithms.rb' + - 'lib/net/ssh/test/script.rb' + - 'lib/net/ssh/authentication/agent/socket.rb' + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/authentication/buffer.rb' + - 'lib/net/ssh/authentication/config.rb' + - 'lib/net/ssh/connection/keepalive.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/proxy/command.rb' + - 'lib/net/ssh/proxy/socks5.rb' + - 'lib/net/ssh/transport/packet_stream.rb' + - 'lib/net/ssh/transport/server_version.rb' + - 'lib/net/ssh/transport/session.rb' + - 'test/authentication/test_key_manager.rb' + - 'test/common.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + +# Offense count: 338 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. +# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets +Style/HashSyntax: + Enabled: false + +# Offense count: 2 +Style/IfInsideElse: + Exclude: + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/key_factory.rb' + +# Offense count: 8 +# Cop supports --auto-correct. +# Configuration parameters: MaxLineLength. +Style/IfUnlessModifier: + Exclude: + - 'lib/net/ssh.rb' + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/proxy/command.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/ctr.rb' + - 'lib/net/ssh/transport/key_expander.rb' + - 'test/integration/test_proxy.rb' + - 'test/test_key_factory.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_brackets +Style/IndentArray: + Enabled: false + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: IndentationWidth. +Style/IndentAssignment: + Exclude: + - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp256.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp384.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp521.rb' + +# Offense count: 216 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: normal, rails +Style/IndentationConsistency: + Enabled: false + +# Offense count: 93 +# Cop supports --auto-correct. +# Configuration parameters: Width. +Style/IndentationWidth: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +Style/InfiniteLoop: + Exclude: + - 'lib/net/ssh/authentication/pageant.rb' + +# Offense count: 33 +# Cop supports --auto-correct. +Style/LeadingCommentSpace: + Exclude: + - 'quicktest.rb' + - 'quicktest_1_open_channel_nb.rb' + - 'quicktest_337.rb' + - 'quicktest_keepalive.rb' + - 'test/integration/test_ed25519_pkeys.rb' + - 'test/integration/test_forward.rb' + - 'test/integration/test_id_rsa_keys.rb' + - 'test/integration/test_proxy.rb' + +# Offense count: 29 +# Cop supports --auto-correct. +Style/LineEndConcatenation: + Exclude: + - 'lib/net/ssh/authentication/pageant.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' + - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb' + - 'lib/net/ssh/verifiers/secure.rb' + +# Offense count: 52 +# Cop supports --auto-correct. +Style/MethodCallParentheses: + Exclude: + - 'quicktest_337.rb' + - 'test/authentication/test_key_manager.rb' + - 'test/connection/test_session.rb' + - 'test/integration/test_forward.rb' + - 'test/start/test_user_nil.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline +Style/MethodDefParentheses: + Enabled: false + +# Offense count: 22 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: snake_case, camelCase +Style/MethodName: + Enabled: false + +# Offense count: 3 +# Cop supports --auto-correct. +Style/MultilineIfThen: + Exclude: + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/service/forward.rb' + +# Offense count: 24 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: aligned, indented +Style/MultilineOperationIndentation: + Enabled: false + +# Offense count: 1 +Style/MultilineTernaryOperator: + Exclude: + - 'lib/net/ssh/authentication/agent.rb' + +# Offense count: 49 +# Cop supports --auto-correct. +Style/MutableConstant: + Enabled: false + +# Offense count: 14 +# Cop supports --auto-correct. +Style/NegatedIf: + Exclude: + - 'lib/net/ssh.rb' + - 'lib/net/ssh/authentication/key_manager.rb' + - 'lib/net/ssh/prompt.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/algorithms.rb' + - 'lib/net/ssh/transport/hmac/abstract.rb' + - 'lib/net/ssh/transport/session.rb' + - 'lib/net/ssh/transport/state.rb' + - 'test/test_key_factory.rb' + - 'test/transport/test_state.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/NegatedWhile: + Exclude: + - 'lib/net/ssh/config.rb' + +# Offense count: 2 +Style/NestedTernaryOperator: + Exclude: + - 'lib/net/ssh/authentication/agent.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. +# SupportedStyles: skip_modifier_ifs, always +Style/Next: + Exclude: + - 'lib/net/ssh/authentication/key_manager.rb' + - 'lib/net/ssh/transport/algorithms.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Style/NilComparison: + Exclude: + - 'lib/net/ssh/proxy/command.rb' + - 'lib/net/ssh/transport/openssl.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +Style/Not: + Exclude: + - 'lib/net/ssh/connection/channel.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +Style/NumericLiterals: + MinDigits: 310 + +# Offense count: 2 +Style/OpMethod: + Exclude: + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/version.rb' + +# Offense count: 16 +# Cop supports --auto-correct. +Style/ParallelAssignment: + Exclude: + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/connection/channel.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/errors.rb' + - 'lib/net/ssh/test/socket.rb' + - 'lib/net/ssh/version.rb' + - 'test/authentication/test_agent.rb' + - 'test/common.rb' + - 'test/connection/test_channel.rb' + +# Offense count: 7 +# Cop supports --auto-correct. +# Configuration parameters: AllowSafeAssignment. +Style/ParenthesesAroundCondition: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/cipher_factory.rb' + - 'lib/net/ssh/transport/ctr.rb' + - 'test/integration/test_proxy.rb' + +# Offense count: 9 +# Cop supports --auto-correct. +# Configuration parameters: PreferredDelimiters. +Style/PercentLiteralDelimiters: + Exclude: + - 'Rakefile' + - 'net-ssh.gemspec' + - 'test/test_config.rb' + +# Offense count: 17 +# Cop supports --auto-correct. +Style/PerlBackrefs: + Exclude: + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/key_factory.rb' + - 'lib/net/ssh/proxy/command.rb' + - 'lib/net/ssh/proxy/socks5.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'test/integration/common.rb' + +# Offense count: 14 +# Cop supports --auto-correct. +Style/Proc: + Exclude: + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/test/channel.rb' + - 'lib/net/ssh/transport/algorithms.rb' + - 'lib/net/ssh/verifiers/secure.rb' + - 'test/authentication/methods/test_hostbased.rb' + - 'test/authentication/methods/test_publickey.rb' + - 'test/connection/test_channel.rb' + - 'test/connection/test_session.rb' + +# Offense count: 7 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: compact, exploded +Style/RaiseArgs: + Enabled: false + +# Offense count: 8 +# Cop supports --auto-correct. +Style/RedundantBegin: + Exclude: + - 'lib/net/ssh/authentication/agent/socket.rb' + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/verifiers/strict.rb' + - 'test/manual/test_pageant.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/RedundantParentheses: + Exclude: + - 'support/arcfour_check.rb' + +# Offense count: 49 +# Cop supports --auto-correct. +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: + Enabled: false + +# Offense count: 11 +# Cop supports --auto-correct. +Style/RedundantSelf: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + - 'lib/net/ssh/connection/channel.rb' + - 'lib/net/ssh/test/extensions.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'test/authentication/test_ed25519.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +Style/RescueModifier: + Exclude: + - 'lib/net/ssh/service/forward.rb' + - 'lib/net/ssh/transport/algorithms.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Style/SelfAssignment: + Exclude: + - 'lib/net/ssh/config.rb' + - 'quicktest_337.rb' + +# Offense count: 10 +# Cop supports --auto-correct. +# Configuration parameters: AllowAsExpressionSeparator. +Style/Semicolon: + Exclude: + - 'lib/net/ssh/buffer.rb' + - 'quicktest_337.rb' + - 'test/connection/test_channel.rb' + - 'test/connection/test_session.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp256.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: only_raise, only_fail, semantic +Style/SignalException: + Exclude: + - 'lib/net/ssh/config.rb' + - 'lib/net/ssh/connection/channel.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: AllowIfMethodIsEmpty. +Style/SingleLineMethods: + Exclude: + - 'lib/net/ssh/buffered_io.rb' + +# Offense count: 17 +# Cop supports --auto-correct. +Style/SpaceAfterColon: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + - 'quicktest_keepalive.rb' + - 'test/integration/test_ed25519_pkeys.rb' + - 'test/verifiers/test_secure.rb' + +# Offense count: 247 +# Cop supports --auto-correct. +Style/SpaceAfterComma: + Enabled: false + +# Offense count: 131 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: space, no_space +Style/SpaceAroundEqualsInParameterDefault: + Enabled: false + +# Offense count: 56 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment. +Style/SpaceAroundOperators: + Enabled: false + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: space, no_space +Style/SpaceBeforeBlockBraces: + Enabled: false + +# Offense count: 4 +# Cop supports --auto-correct. +Style/SpaceBeforeComma: + Exclude: + - 'test/integration/test_forward.rb' + - 'test/integration/test_proxy.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment. +Style/SpaceBeforeFirstArg: + Exclude: + - 'lib/net/ssh/transport/hmac/sha2_256_96.rb' + - 'lib/net/ssh/transport/hmac/sha2_512_96.rb' + - 'test/authentication/test_key_manager.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/SpaceBeforeSemicolon: + Exclude: + - 'quicktest_337.rb' + +# Offense count: 30 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +Style/SpaceInsideBlockBraces: + Enabled: false + +# Offense count: 40 +# Cop supports --auto-correct. +Style/SpaceInsideBrackets: + Exclude: + - 'Rakefile' + - 'lib/net/ssh/transport/algorithms.rb' + - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb' + - 'test/integration/test_forward.rb' + - 'test/start/test_options.rb' + +# Offense count: 46 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. +# SupportedStyles: space, no_space +Style/SpaceInsideHashLiteralBraces: + Enabled: false + +# Offense count: 13 +# Cop supports --auto-correct. +Style/SpaceInsideParens: + Exclude: + - 'lib/net/ssh/transport/algorithms.rb' + - 'lib/net/ssh/transport/openssl.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +Style/SpaceInsideRangeLiteral: + Exclude: + - 'lib/net/ssh/authentication/ed25519.rb' + - 'lib/net/ssh/transport/algorithms.rb' + +# Offense count: 40 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: use_perl_names, use_english_names +Style/SpecialGlobalVars: + Enabled: false + +# Offense count: 1739 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes +Style/StringLiterals: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: single_quotes, double_quotes +Style/StringLiteralsInInterpolation: + Enabled: false + +# Offense count: 17 +# Cop supports --auto-correct. +# Configuration parameters: IgnoredMethods. +# IgnoredMethods: respond_to +Style/SymbolProc: + Exclude: + - 'lib/net/ssh/authentication/session.rb' + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/connection/session.rb' + - 'lib/net/ssh/test/extensions.rb' + - 'lib/net/ssh/transport/algorithms.rb' + - 'test/integration/test_forward.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/Tab: + Exclude: + - 'lib/net/ssh/config.rb' + +# Offense count: 41 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: final_newline, final_blank_line +Style/TrailingBlankLines: + Enabled: false + +# Offense count: 255 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. +# SupportedStyles: comma, consistent_comma, no_comma +Style/TrailingCommaInLiteral: + Exclude: + - 'lib/net/ssh/key_factory.rb' + - 'lib/net/ssh/transport/cipher_factory.rb' + - 'lib/net/ssh/transport/kex.rb' + - 'lib/net/ssh/transport/openssl.rb' + - 'test/transport/test_packet_stream.rb' + +# Offense count: 120 +# Cop supports --auto-correct. +Style/TrailingWhitespace: + Enabled: false + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. +# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym +Style/TrivialAccessors: + Exclude: + - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +Style/UnlessElse: + Exclude: + - 'lib/net/ssh/buffer.rb' + - 'lib/net/ssh/transport/ctr.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp256.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp384.rb' + - 'test/transport/kex/test_ecdh_sha2_nistp521.rb' + - 'test/transport/test_server_version.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +Style/UnneededInterpolation: + Exclude: + - 'lib/net/ssh/proxy/socks5.rb' + - 'lib/net/ssh/transport/session.rb' + - 'test/integration/test_forward.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +Style/UnneededPercentQ: + Exclude: + - 'net-ssh.gemspec' + - 'test/test_config.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Style/WhileUntilDo: + Exclude: + - 'lib/net/ssh/config.rb' + - 'test/integration/common.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: SupportedStyles, WordRegex. +# SupportedStyles: percent, brackets +Style/WordArray: + EnforcedStyle: percent + MinSize: 3 + +# Offense count: 7 +# Cop supports --auto-correct. +Style/ZeroLengthPredicate: + Exclude: + - 'lib/net/ssh/buffered_io.rb' + - 'lib/net/ssh/connection/channel.rb' + - 'test/integration/test_forward.rb' + - 'test_connection_close_shall_close_cannels.rb' diff --git a/test/common.rb b/test/common.rb index dfb3cc0..03d5e29 100644 --- a/test/common.rb +++ b/test/common.rb @@ -11,7 +11,7 @@ require 'ostruct' # clear the default files out so that tests don't get confused by existing # SSH config files. -$original_config_default_files = Net::SSH::Config.default_files.dup +_original_config_default_files = Net::SSH::Config.default_files.dup Net::SSH::Config.default_files.clear def P(*args) |