Bugfix: proxy command was using nonblocking io api incorrectly causing rare IO::EAGAIN errors

FIXES #122

1 files changed, 93 insertions, 0 deletions

diff --git a/test/integration/test_proxy.rb b/test/integration/test_proxy.rb
new file mode 100644
index 0000000..f9ae3da
--- /dev/null
+++ b/test/integration/test_proxy.rb
@@ -0,0 +1,93 @@
+require_relative './common'
+require 'net/ssh/buffer'
+require 'net/ssh'
+require 'timeout'
+require 'tempfile'
+require 'net/ssh/proxy/command'
+
+class TestProxy < Test::Unit::TestCase
+  include IntegrationTestHelpers
+
+  def localhost
+    'localhost'
+  end
+
+  def user
+    'net_ssh_1'
+  end
+
+  def ssh_start_params(options)
+    [localhost ,user , {:keys => @key_id_rsa, :verbose => :debug}.merge(options)]
+  end
+
+  def setup_ssh_env(&block)
+    tmpdir do |dir|
+      @key_id_rsa = "#{dir}/id_rsa"
+      sh "rm -rf #{@key_id_rsa} #{@key_id_rsa}.pub"
+      sh "ssh-keygen -f #{@key_id_rsa} -t rsa -N ''"
+      set_authorized_key(user,"#{@key_id_rsa}.pub")
+      yield
+    end
+  end
+
+  def test_smoke
+    setup_ssh_env do
+      proxy = Net::SSH::Proxy::Command.new("/bin/nc localhost 22")
+      msg = 'echo123'
+      ret = Net::SSH.start(*ssh_start_params(:proxy => proxy)) do |ssh|
+        ssh.exec! "echo \"$USER:#{msg}\""
+      end
+      assert_equal "net_ssh_1:#{msg}\n", ret
+    end
+  end
+
+  def with_spurious_write_wakeup_emulate(rate=99,&block)
+    orig_io_select = Net::SSH::Compat.method(:io_select)
+    count = 0
+    Net::SSH::Compat.singleton_class.send(:define_method,:io_select) do |*params|
+      count += 1
+      if (count % rate != 0)
+        if params && params[1] && !params[1].empty?
+          return [[],params[1],[]]
+        end
+        #if params && params[0] && !params[0].empty?
+        #return [params[0],[],[]]
+        #end
+      end
+      IO.select(*params)
+    end
+    begin
+      yield
+    ensure
+      Net::SSH::Compat.singleton_class.send(:define_method,:io_select,&orig_io_select)
+    end
+  end
+
+  def test_with_rate_limit_and_spurious_wakeup
+    system("sudo sh -c 'echo 4096 > /proc/sys/fs/pipe-max-size'")
+    begin
+      setup_ssh_env do
+        proxy = Net::SSH::Proxy::Command.new("/usr/bin/pv --rate-limit 100k | /bin/nc localhost 22")
+        #proxy = Net::SSH::Proxy::Command.new("/bin/nc localhost 22")
+        begin
+          large_msg = 'echo123'*30000
+          ok = Net::SSH.start(*ssh_start_params(:proxy => proxy)) do |ssh|
+              with_spurious_write_wakeup_emulate do
+                ret = ssh.exec! "echo \"$USER:#{large_msg}\""
+                #assert_equal "net_ssh_1:#{large_msg}\n", ret
+                assert_equal "/bin/sh: Argument list too long\n", ret
+                hello_count = 1000
+                ret = ssh.exec! "ruby -e 'puts \"Hello\"*#{hello_count}'"
+                assert_equal "Hello"*hello_count+"\n", ret
+              end
+              :ok
+            end
+        end
+        assert_equal :ok, ok
+      end
+    ensure
+      system("sudo sh -c 'echo 1048576 > /proc/sys/fs/pipe-max-size'")
+    end
+  end
+
+end
\ No newline at end of file